Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGmXU-0003kU-KV for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Jul 2022 19:17:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oGmXS-0007qq-Md for pgsql-hackers@arkaria.postgresql.org; Wed, 27 Jul 2022 19:17:46 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGmXS-0007qh-CR for pgsql-hackers@lists.postgresql.org; Wed, 27 Jul 2022 19:17:46 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oGmXM-0005Ck-4S for pgsql-hackers@lists.postgresql.org; Wed, 27 Jul 2022 19:17:45 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 26RJHaHA3058598; Wed, 27 Jul 2022 15:17:36 -0400 From: Tom Lane To: Alvaro Herrera cc: Robert Haas , PostgreSQL Hackers Subject: Re: pgsql: Remove the restriction that the relmap must be 512 bytes. In-reply-to: <20220727184523.n7emhydwhnegd2ci@alvherre.pgsql> References: <20220727184523.n7emhydwhnegd2ci@alvherre.pgsql> Comments: In-reply-to Alvaro Herrera message dated "Wed, 27 Jul 2022 20:45:23 +0200" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3058596.1658949456.1@sss.pgh.pa.us> Date: Wed, 27 Jul 2022 15:17:36 -0400 Message-ID: <3058597.1658949456@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Alvaro Herrera writes: >> Hmm, but that doesn't actually produce nice behavior. It just goes >> into an infinite loop, like this: >> So now I'm back to being unsure what to do here. > I vote to go for the catversion bump for now. What this is showing us is that any form of corruption in the relmapper file causes very unpleasant behavior. We probably had better do something about that, independently of this issue. In the meantime, I still think bumping the file magic number is a better answer. It won't make the behavior any worse for un-updated code than it is already. regards, tom lane