From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@2ndquadrant.com>
cc: pgsql-hackers@postgresql.org
Subject: Re: [COMMITTERS] pgsql: Preventive maintenance in advance of pgindent
 run.
In-reply-to: <20170517140847.lasiafwmsxgzppm6@alvherre.pgsql>
References: <20170517140847.lasiafwmsxgzppm6@alvherre.pgsql>
Comments: In-reply-to Alvaro Herrera <alvherre@2ndquadrant.com>
	message dated "Wed, 17 May 2017 10:08:47 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <30658.1495030469.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Wed, 17 May 2017 10:14:29 -0400
Message-ID: <30659.1495030469@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-hackers-owner@postgresql.org

Alvaro Herrera <alvherre@2ndquadrant.com> writes:
> There are some changes here that should be reverted; for instance:

> -   printf(_("  -c, --checkpoint=3Dfast|spread\n"
> -            "                         set fast or spread checkpointing\n=
"));
> +   printf(_("  -c, --checkpoint=3Dfast|spread\n"));
> +   printf(_("                         set fast or spread checkpointing\n=
"));

> From the translator's point of view the patched version doesn't make
> sense because they are two separate strings.  In the original, it's a
> single translatable string.  Particularly in pg_waldump's -p, where a
> phrase is now cut in the middle.

What I was concerned about was that pgindent will reindent the second
line so that it's impossible to tell whether the spacing is correct.
That might not matter to translators but it will be a problem for
source-level maintenance.

Maybe we should rethink the whole idea of breaking these entries across
lines, and just accept that the commentary doesn't line up with other
lines:

   printf(_("  -c, --checkpoint=3Dfast|spread  set fast or spread checkpoin=
ting\n"));

Thoughts?

			regards, tom lane


--=20
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers