Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nc7S6-00058l-Js for pgsql-committers@arkaria.postgresql.org; Wed, 06 Apr 2022 15:20:10 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nc7S5-0004mx-E2 for pgsql-committers@arkaria.postgresql.org; Wed, 06 Apr 2022 15:20:09 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nc7S5-0004mo-7I for pgsql-committers@lists.postgresql.org; Wed, 06 Apr 2022 15:20:09 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nc7S1-0006zm-Nz for pgsql-committers@lists.postgresql.org; Wed, 06 Apr 2022 15:20:08 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 236FK2Ff3084517; Wed, 6 Apr 2022 11:20:02 -0400 From: Tom Lane To: Andrew Dunstan cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Reduce running time of jsonb_sqljson test In-reply-to: References: Comments: In-reply-to Andrew Dunstan message dated "Wed, 06 Apr 2022 14:30:45 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3084515.1649258402.1@sss.pgh.pa.us> Date: Wed, 06 Apr 2022 11:20:02 -0400 Message-ID: <3084516.1649258402@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > The test created a 1m row table in order to test parallel operation of > JSON_VALUE. Egad. > However, this was more than were needed for the test, so > save time by halving it, and also by making the table unlogged. This seems like a rather inappropriate fix. I would say that a test of this size does not belong in the core regression tests AT ALL. regards, tom lane