Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtp (Exim 4.84_2) (envelope-from ) id 1cHRgR-0003td-Ez for pgsql-committers@arkaria.postgresql.org; Thu, 15 Dec 2016 08:46:35 +0000 Received: from localhost ([127.0.0.1] helo=postgresql.org) by malur.postgresql.org with smtp (Exim 4.84_2) (envelope-from ) id 1cHRgR-0005nD-1q for pgsql-committers@arkaria.postgresql.org; Thu, 15 Dec 2016 08:46:35 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1cHRgQ-0005mz-79 for pgsql-committers@postgresql.org; Thu, 15 Dec 2016 08:46:34 +0000 Received: from mail-wm0-x22b.google.com ([2a00:1450:400c:c09::22b]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.84_2) (envelope-from ) id 1cHRgM-0007wo-VZ for pgsql-committers@postgresql.org; Thu, 15 Dec 2016 08:46:33 +0000 Received: by mail-wm0-x22b.google.com with SMTP id t79so34253421wmt.0 for ; Thu, 15 Dec 2016 00:46:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=2ndquadrant-com.20150623.gappssmtp.com; s=20150623; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to; bh=XO8CZvsiaZepFX3xxn2BPU2UAMpxruq6z6BSKIFGegw=; b=Aeg8mquyp1nd6/Jp8Pciw2YuzbVe025V0KEMVrBe/Z4BK5Zc8gvt2vXkRd+8cV3nAW ldnnDxtJC8j2xGCL+Z8CO34aul1k9cWolKykaUzNdpLWlNssXt1CAZE3XYeF42X2IWhO 3VzA4VlhZ5+04OK05Wu062r1LcABAKNowVTsPXT3o2rsGvl4IDdk+sAVnVpKZrmd3aOd Tbl+cJoohlIITW2iDGdP8QECmYSknOM1JjFCLQJokbpwaVLe27FyWukVpilt8kfeN7ps X7pXnxHuYirapsySuHYS+9quXYw8rS1c0eLsBgvA2VIwiHuZCkIK+94UXYc6BRf3i9fv 3eeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:cc:from:message-id:date :user-agent:mime-version:in-reply-to; bh=XO8CZvsiaZepFX3xxn2BPU2UAMpxruq6z6BSKIFGegw=; b=tkfjHTgDnH4YH/wYhI7i18ht1G9Bf9eJzqqwoan85MkYTSFIwXFYYYeIdcPsjub85i Qz0te9ZEGi3pj1X/J00ohAlN+/PzSz1waiyM2knSVmmPiZfCM8WN4DUY+4EUr/iqCMrT X2eNjJCSEmnI7YoRnFrxhZf+Pd6+V8H7Dk07PV3mN/pEOT7TTrVfxZSYxCCKnZZZhiO7 4jA0WPaqi5ohAK34UmUUdlm1zCFURfN/rH7dXMc8FeIqrcFkzSy9s7WMxvZQdzf7xeuK NnNv/WxokrhQ3muN8iEnvY9ADLPKfGIFMaqx/Kxu2GqL1eRvML+uCm5LE0bg1K0fW11h Vdgw== X-Gm-Message-State: AIkVDXLcwydeQ3AXte8iUYZuI5qF5Sj0IUAydum99hdYWBjlp6tzJ24XWd8xZVhuIPXxHPGa3ztsUa8jBw3Aw3TyCgQLyC+qYesxVyGbuBE7T6k7aCTDHZyqU1qZBuEKR1btYIJiGcahPteTR9vjnp5g+DRjcN0PuZALgtasMR+M7vOT/V+SKM7ED6KRN+bLJ2lZH/uTPfvLzlQq X-Received: by 10.28.165.2 with SMTP id o2mr267515wme.38.1481791588807; Thu, 15 Dec 2016 00:46:28 -0800 (PST) Received: from [192.168.0.105] (150.123.broadband11.iol.cz. [90.178.123.150]) by smtp.gmail.com with ESMTPSA id y4sm1033400wjp.0.2016.12.15.00.46.27 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 15 Dec 2016 00:46:28 -0800 (PST) Subject: Re: pgsql: Add support for temporary replication slots To: Peter Eisentraut , Andres Freund References: <27274.1481557380@sss.pgh.pa.us> <27833.1481558144@sss.pgh.pa.us> <62935e6f-4f1b-c433-e0fa-7f936a38b3e5@2ndquadrant.com> <22907.1481571177@sss.pgh.pa.us> <15713.1481585953@sss.pgh.pa.us> <314cae39-2e7d-f5a3-d226-cfb80cf80481@2ndquadrant.com> <18684.1481589637@sss.pgh.pa.us> <48b2c017-695d-b5ac-2ff4-89b939b3e8f9@2ndquadrant.com> <20161213004903.iito2pefdrrjgny5@alap3.anarazel.de> <6886c56a-f6c8-3c44-53a1-dae6c24afb76@2ndquadrant.com> <20161213010059.dn64rrb3u7zxnnwk@alap3.anarazel.de> <3c8c413d-b476-93d2-652f-011a589a2d74@2ndquadrant.com> Cc: Tom Lane , pgsql-committers@postgresql.org From: Petr Jelinek Message-ID: <309c14fa-e043-a353-366e-3ce0aab527c8@2ndquadrant.com> Date: Thu, 15 Dec 2016 09:46:27 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.5.1 MIME-Version: 1.0 In-Reply-To: <3c8c413d-b476-93d2-652f-011a589a2d74@2ndquadrant.com> Content-Type: multipart/mixed; boundary="------------D008685499BA45586C8D44D8" X-Pg-Spam-Score: -2.6 (--) List-Archive: List-Help: List-ID: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: X-Mailing-List: pgsql-committers Precedence: bulk Sender: pgsql-committers-owner@postgresql.org This is a multi-part message in MIME format. --------------D008685499BA45586C8D44D8 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 14/12/16 15:35, Peter Eisentraut wrote: > On 12/12/16 8:28 PM, Petr Jelinek wrote: >> On 13/12/16 02:00, Andres Freund wrote: >>> On 2016-12-13 01:57:01 +0100, Petr Jelinek wrote: >>>> I mentioned that as possible solution upthread, I am only worried that >>>> the failure scenario is basically infinite loop. >>> >>> I don't see the problem with that. If you're really concerned you can >>> set a statement timeout. >>> >> >> Okay in case we decide it's the right way to go attached patch does >> that. I also added some more tests based on your feedback while I am at it. > > This looks mostly reasonable to me, but the location and xid output from > pg_logical_slot_get_changes() is not portable/repeatable, so it should > be omitted from the output. > Sigh, yes you are right. -- Petr Jelinek http://www.2ndQuadrant.com/ PostgreSQL Development, 24x7 Support, Training & Services --------------D008685499BA45586C8D44D8 Content-Type: text/x-diff; name="0001-Various-temporary-slots-test-improvements.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename*0="0001-Various-temporary-slots-test-improvements.patch"