Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps
 (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1jJOX8-0006my-OM
	for pgsql-committers@arkaria.postgresql.org; Tue, 31 Mar 2020 21:34:54 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.92)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1jJOX7-0006SW-ES
	for pgsql-committers@arkaria.postgresql.org; Tue, 31 Mar 2020 21:34:53 +0000
Received: from makus.postgresql.org ([2001:4800:3e1:1::229])
	by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jJOX7-0006SP-8q
	for pgsql-committers@lists.postgresql.org; Tue, 31 Mar 2020 21:34:53 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
	(Exim 4.92)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1jJOX5-0005aP-7a
	for pgsql-committers@lists.postgresql.org; Tue, 31 Mar 2020 21:34:52 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 02VLYoJ5031073;
	Tue, 31 Mar 2020 17:34:50 -0400
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Bruce Momjian <bruce@momjian.us>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: dummy commit
In-reply-to: <E1jJOQ8-0004k4-9W@gemulon.postgresql.org>
References: <E1jJOQ8-0004k4-9W@gemulon.postgresql.org>
Comments: In-reply-to Bruce Momjian <bruce@momjian.us>
	message dated "Tue, 31 Mar 2020 21:27:40 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31071.1585690490.1@sss.pgh.pa.us>
Date: Tue, 31 Mar 2020 17:34:50 -0400
Message-ID: <31072.1585690490@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

Bruce Momjian <bruce@momjian.us> writes:
> dummy commit

Uh, what?

Also, I disagree with your change of the wording about savepoint
rollbacks.  I agree that "if the savepoint is rolled back to"
is a bit awkward, but I think dropping the "to" is flat wrong.
The savepoint is a point you roll back to, it doesn't itself
disappear when you do so.  That's why the SQL syntax is
"ROLLBACK TO savepoint" and not just "ROLLBACK savepoint".

			regards, tom lane