Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYkjm-00DnSl-Dl for pgsql-committers@arkaria.postgresql.org; Tue, 30 Jul 2024 11:09:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1sYkjk-008dla-SX for pgsql-committers@arkaria.postgresql.org; Tue, 30 Jul 2024 11:09:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYkjk-008dko-HG for pgsql-committers@lists.postgresql.org; Tue, 30 Jul 2024 11:09:48 +0000 Received: from lahtoruutu.iki.fi ([2a0b:5c81:1c1::37]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1sYkjh-002Ea1-Hn for pgsql-committers@lists.postgresql.org; Tue, 30 Jul 2024 11:09:47 +0000 Received: from [192.168.1.121] (dsl-hkibng22-54f8db-125.dhcp.inet.fi [84.248.219.125]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: hlinnaka) by lahtoruutu.iki.fi (Postfix) with ESMTPSA id 4WYCDR4mcKz49Pv5; Tue, 30 Jul 2024 14:09:43 +0300 (EEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1722337783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u3zD2/6RwQ0Usq7lW2NNWTsxPCCKAjfAML1PIMksLT8=; b=gqrpV9qLr+D+P+OG57ChinjgLBVTNf9odFYRei+RdjniEKbNP6hZ19PPlSCfnWM5IM2mlZ 6D216rFyokyh7ifyjgs8ZCmng2V3QVOZp7/3VCET7Zk6aJmnL1eHIkzuc+aulAulZz1QH4 seDoibbWn0o4QFaoJbcB7DZ3jrtswyHeZE/Y+xRtMWqZmIpkgfbNu9qtcfVKRI/vC2zXfO nV3S2yLqLLm9g21fo/0e3WwiCwABv8Q/mzrsWbO8tJgmgyBw53mcqRO4CP8yV1lxnnJn3T qdjegwQ+MKdAUuB1OllEHZALyPhzXeknW7fGMQKbmhtEFPyX9x69MThm4R0FLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=iki.fi; s=lahtoruutu; t=1722337783; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=u3zD2/6RwQ0Usq7lW2NNWTsxPCCKAjfAML1PIMksLT8=; b=IApryYbO1g8sN9GksWWKSh31QY6Nyu3u1miRcmTe8KXXWupCKHtp9SFadxJblbNdXZdy2H bG4Hn0c0WFUqcdKtWKviij+C231AMKgOY10cMIw/3VwNLGkGBXGXu9xKUYsu6wW509WKDt VzXcvme+Y8Lyj5FZV1TeStxNArXDTuX/MoyQz7SClzpAiZOClWhJk6MghfzLV1Cdnp081w dBgJFAdzJNqne48waMTQ7tGJPo2QRHuO1mEqxlsSWPw4livv6cQb2dQXR9NKLzY94BKIG1 z0cayH1dljkLOO6DRRr9CCVgNowu49myfQgUQgYx1szigNQgzfrxaKb6rVfuHA== ARC-Authentication-Results: i=1; ORIGINATING; auth=pass smtp.auth=hlinnaka smtp.mailfrom=hlinnaka@iki.fi ARC-Seal: i=1; s=lahtoruutu; d=iki.fi; t=1722337783; a=rsa-sha256; cv=none; b=j3F345aqjbSwY+qCWQSoIRoG0q/R3TsXUkukSUzqp8xILSf9XDymk7pVpKyVnyD1PV9IfS 9S7YzUsgCMeXgO8uNQjM2+pzsh/IkWxd/LzVXl/juU/LT2ynHWr5jUoQZkiM9NqNnyJq4y 6evAKz5lKUwiqGBo4ra4zuPYbxXwIYddJRZO0OyRam8RZAuIpkCl2tZlcrawE7NzcQ+NRR DE3iM04G+qj3eLalJPrB0YcpyA9OJ0tGbz2aIcm79npkAWKACp7NtHpBrO8WPuGNAkR8Pr 2D/LwKemu5ocpuTm5cda2sQds36bXNqcNxsgrhTe31+y8mqxMEcVYWHfN+5zLA== Message-ID: <310f4005-91d7-42b2-ac70-92624260dd28@iki.fi> Date: Tue, 30 Jul 2024 14:09:42 +0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: pgsql: Remove --disable-spinlocks. To: Thomas Munro , pgsql-committers@lists.postgresql.org References: Content-Language: en-US From: Heikki Linnakangas In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 30/07/2024 14:03, Thomas Munro wrote: > Remove --disable-spinlocks. Sorry, spotted this only now: > --- a/src/backend/postmaster/launch_backend.c > +++ b/src/backend/postmaster/launch_backend.c > @@ -108,9 +108,7 @@ typedef struct > #ifdef USE_INJECTION_POINTS > struct InjectionPointsCtl *ActiveInjectionPoints; > #endif > -#ifndef HAVE_SPINLOCKS > PGSemaphore *SpinlockSemaArray; > -#endif > int NamedLWLockTrancheRequests; > NamedLWLockTranche *NamedLWLockTrancheArray; > LWLockPadded *MainLWLockArray; The SpinLockSemaArray field should be completely completely, nut just the #ifndef guard around it. -- Heikki Linnakangas Neon (https://neon.tech)