Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYgnc-0003or-Kh for pgsql-committers@arkaria.postgresql.org; Thu, 15 Sep 2022 04:48:28 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oYgnb-00016V-H0 for pgsql-committers@arkaria.postgresql.org; Thu, 15 Sep 2022 04:48:27 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYgnb-00016J-AX for pgsql-committers@lists.postgresql.org; Thu, 15 Sep 2022 04:48:27 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYgnZ-0006zZ-6S for pgsql-committers@lists.postgresql.org; Thu, 15 Sep 2022 04:48:26 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 28F4mMxd3122569; Thu, 15 Sep 2022 00:48:22 -0400 From: Tom Lane To: Bharath Rupireddy cc: Andrew Dunstan , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Use the terminology "WAL file" not "log file" more consistently. In-reply-to: References: <3043210.1663205920@sss.pgh.pa.us> Comments: In-reply-to Bharath Rupireddy message dated "Thu, 15 Sep 2022 10:11:03 +0530" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3122567.1663217302.1@sss.pgh.pa.us> Date: Thu, 15 Sep 2022 00:48:22 -0400 Message-ID: <3122568.1663217302@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Bharath Rupireddy writes: > We seem to be maintaining old code in pg_upgrade to not break it, see > [3]. I can think of a fix [4] or just [5], it may not be great to do > these kinds of fixes for all the pg_resetwal output changes. Since the > changes we make to the output formats of controlfile or pg_resetwal > are very rare, any of [4] or [5] looks good to me and it is better > than backporting [2] IMO. Yeah, the lowest-tech solution is to accept either spelling of the description string. But I'm not very happy with the whole approach right now. We should have an implementation that isn't dependent on how user-friendly strings are spelled. (git seems a bit ahead of us here, with its distinction between "plumbing" and "porcelain" operations.) regards, tom lane