Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iJTZf-0003mZ-LF for pgsql-committers@arkaria.postgresql.org; Sun, 13 Oct 2019 02:25:35 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1iJTYf-0008WV-T9 for pgsql-committers@arkaria.postgresql.org; Sun, 13 Oct 2019 02:24:33 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iJTYf-0008WE-Lr for pgsql-committers@lists.postgresql.org; Sun, 13 Oct 2019 02:24:33 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1iJTYc-0008AX-V2 for pgsql-committers@lists.postgresql.org; Sun, 13 Oct 2019 02:24:33 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id x9D2ORNa031236; Sat, 12 Oct 2019 22:24:27 -0400 From: Tom Lane To: Alexander Korotkov cc: Robert Haas , Nikita Glukhov , pgsql-committers , Alexander Korotkov , pgsql-hackers Subject: Re: pgsql: Implement jsonpath .datetime() method In-reply-to: References: Comments: In-reply-to Alexander Korotkov message dated "Sun, 13 Oct 2019 04:52:21 +0300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <31234.1570933467.1@sss.pgh.pa.us> Date: Sat, 12 Oct 2019 22:24:27 -0400 Message-ID: <31235.1570933467@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Alexander Korotkov writes: > This patch also changes the way timestamp to timestamptz cast works. > Previously it did timestamp2tm() then tm2timestamp(). Instead, after > timestamp2tm() it calculates timezone offset and applies it to > original timestamp value. I hope this is correct. I'd wonder whether this gives the same answers near DST transitions, where it's not real clear which offset applies. Please *don't* wrap this sort of thing into an unrelated feature patch. regards, tom lane