From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <akorotkov@postgresql.org>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix page modification outside of critical section in GIN
In-reply-to: <21620.1581098806@sss.pgh.pa.us>
References: <E1iXAuR-0001k9-Cn@gemulon.postgresql.org>
 <21620.1581098806@sss.pgh.pa.us>
Comments: In-reply-to Tom Lane <tgl@sss.pgh.pa.us>
	message dated "Fri, 07 Feb 2020 13:06:46 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31239.1581267932.1@sss.pgh.pa.us>
Date: Sun, 09 Feb 2020 12:05:32 -0500
Message-ID: <31240.1581267932@sss.pgh.pa.us>
Precedence: bulk

I wrote:
> Alexander Korotkov <akorotkov@postgresql.org> writes:
>> Fix page modification outside of critical section in GIN

> I happened to notice, while reviewing stuff for the release notes,
> that this patch does not do what the commit message says.  The
> previous code modified the pd_prune_xid of the "dBuffer" page,
> but now it's modifying the pd_prune_xid of the "lBuffer" page.
> Is that actually correct?

Since we're rapidly approaching the wrap deadline for this week's
releases, I took it upon myself to review this code more carefully,
and concluded that indeed it isn't correct.  I pushed a fix that
moves the GinPageSetDeleteXid call again.

			regards, tom lane