From: Tom Lane <tgl@sss.pgh.pa.us>
To: Thomas Munro <thomas.munro@gmail.com>
cc: Alvaro Herrera <alvherre@alvh.no-ip.org>,
        Fabien COELHO <coelho@cri.ensmp.fr>,
        Thomas Munro <tmunro@postgresql.org>,
        pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Track LLVM 15 changes.
In-reply-to: 
 <CA+hUKG+LX+mjBTPV=u4RnZU_5sp=BgCHh_91a1f1NFoKphtJWQ@mail.gmail.com>
References: 
 <CA+hUKGLqengPszjoQeD_7nmHsjGZS380+ymke-Fm=nNGMEQuhw@mail.gmail.com>
 <202202142122.eqz4mu2ecfes@alvherre.pgsql>
 <CA+hUKG+LX+mjBTPV=u4RnZU_5sp=BgCHh_91a1f1NFoKphtJWQ@mail.gmail.com>
Comments: In-reply-to Thomas Munro <thomas.munro@gmail.com>
	message dated "Tue, 15 Feb 2022 11:15:24 +1300"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3155480.1644950069.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Tue, 15 Feb 2022 13:34:29 -0500
Message-ID: <3155481.1644950069@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3155481.1644950069%40sss.pgh.pa.us>
Precedence: bulk

Thomas Munro <thomas.munro@gmail.com> writes:
> This really depends on *their* release cycle, not ours.  Hmm.  Well,
> if we had a buildfarm animal that ran their latest release branch as
> recently discussed, not their main branch, then we could say "if that
> machine is failing, but seawasp is passing, now is the time to
> back-patch all the 'Track LLVM X' patches; if seawasp is failing, we
> should urgently look into why".  I'm willing to set such an animal up,
> but Fabien or Andres may want to... A bit of shell scripting to peek
> at their branches or look for their RC1 tag or something like that
> depending on what we decide is the right trigger point.

Although seawasp isn't actually failing at the moment, it's emitting
a boatload of deprecation warnings, eg

In file included from llvmjit_deform.c:27:
../../../../src/include/jit/llvmjit_emit.h:112:23: warning: 'LLVMBuildStru=
ctGEP' is deprecated: Use LLVMBuildStructGEP2 instead to support opaque po=
inters [-Wdeprecated-declarations]
        LLVMValueRef v_ptr =3D LLVMBuildStructGEP(b, v, idx, "");
                             ^
/home/fabien/clgtk/include/llvm-c/Core.h:3908:1: note: 'LLVMBuildStructGEP=
' has been explicitly marked deprecated here
LLVM_ATTRIBUTE_C_DEPRECATED(
^

Is that on anyone's radar to clean up?

			regards, tom lane