Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nK39F-0006Km-LP for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Feb 2022 19:06:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nK38j-0001Qn-1K for pgsql-hackers@arkaria.postgresql.org; Tue, 15 Feb 2022 19:05:29 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nK38i-0001Qd-OK for pgsql-hackers@lists.postgresql.org; Tue, 15 Feb 2022 19:05:28 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nK38f-0007uz-Ow for pgsql-hackers@postgresql.org; Tue, 15 Feb 2022 19:05:28 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 21FJ5JKK3158141; Tue, 15 Feb 2022 14:05:19 -0500 From: Tom Lane To: Robert Haas cc: Joe Conway , Peter Eisentraut , PostgreSQL-development Subject: Re: pgsql: Move scanint8() to numutils.c In-reply-to: References: <58cca3e9-53b8-e824-7cd4-6e59b4e242b1@joeconway.com> Comments: In-reply-to Robert Haas message dated "Tue, 15 Feb 2022 13:47:26 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3158139.1644951919.1@sss.pgh.pa.us> Date: Tue, 15 Feb 2022 14:05:19 -0500 Message-ID: <3158140.1644951919@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Robert Haas writes: > On Tue, Feb 15, 2022 at 10:39 AM Joe Conway wrote: >> scanint8() is exported, and this change breaks at least two extensions I >> maintain. > I don't have a particularly strong view on whether the underlying > change was a good idea here, but the breakage you're talking about > seems pretty easy to fix, unless I'm missing something? I think it > would be a bad idea to make such a change in a minor release without > concern for extension breakage, but in a new major release it doesn't > seem like a problem to me. Yeah, this seems well within our expectations for major-release changes. regards, tom lane