Subject: Re: pgsql: Add a regression test for allow_system_table_mods
To: Tom Lane <tgl@sss.pgh.pa.us>
References: <E1iacW7-0003h6-6U@gemulon.postgresql.org>
 <13656.1575041267@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
From: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Organization: 2ndQuadrant
Message-ID: <315cfd3b-9d04-0ea4-76d8-1507c8bd9bb7@2ndquadrant.com>
Date: Fri, 29 Nov 2019 17:04:45 +0100
User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0)
 Gecko/20100101 Thunderbird/52.9.1
MIME-Version: 1.0
In-Reply-To: <13656.1575041267@sss.pgh.pa.us>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Precedence: bulk

On 2019-11-29 16:27, Tom Lane wrote:
> Peter Eisentraut <peter@eisentraut.org> writes:
>> Add a regression test for allow_system_table_mods
> 
> Oooh ... some of the buildfarm members are pointing out that this
> didn't follow a project convention:

Um, yes, that's why it's in unsafe_tests.  Is there a way around this?

> 
> @@ -153,6 +153,7 @@
>   ROLLBACK;
>   -- reserved tablespace name
>   CREATE TABLESPACE pg_foo LOCATION '/no/such/location';
> +WARNING:  tablespaces created by regression test cases should have names starting with "regress_"
>   ERROR:  directory "/no/such/location" does not exist
>   -- triggers
>   CREATE TRIGGER t1 BEFORE INSERT ON pg_description EXECUTE FUNCTION tf1();
> 
> 			regards, tom lane
> 


-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services