Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVr65-0003NT-9r for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Sep 2022 09:11:49 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oVr64-0005gT-5v for pgsql-hackers@arkaria.postgresql.org; Wed, 07 Sep 2022 09:11:48 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVr63-0005ZB-7n for pgsql-hackers@lists.postgresql.org; Wed, 07 Sep 2022 09:11:47 +0000 Received: from out5-smtp.messagingengine.com ([66.111.4.29]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oVr5z-0006zF-04 for pgsql-hackers@postgresql.org; Wed, 07 Sep 2022 09:11:46 +0000 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id CB31E5C00F2; Wed, 7 Sep 2022 05:11:39 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 07 Sep 2022 05:11:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:feedback-id:feedback-id:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to:x-me-proxy:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t=1662541899; x= 1662628299; bh=nFzl/tpOX3wIHI8OtU6vzPozTGiZlGhkYLASrbILMG4=; b=x Vd6Vw3bGo72nsBtppk3tvyondzqtsEKFEqsORQN2OvDrhl+egUo0OpvjKyYRNFVY SPK2kf5VX0uf4LqaPsACcOHxq1/dJNhOWoZRtt+VOvfFZg0TYpojo2kwqpT2cHaK z6zu9LXQfKigY8TNF2UeVYWncfPtSr5Lxvoh4PXTNSo4B9ATZxNr8EQ8WEPG1CnV M/nlk1ZeMelsrVBbQwZg5fnJsYRM6bFcJpQBw9D90BmNjVAykw7lO7YpUKeCNo1C 4ywMJAsP+eGpOTEZZiCtj1AY8yCfgHHWS41kWyi65DV3DTGPnbkll5890TLRcFTS nmqcfwWkzF+f3zRaJhIXQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrfedttddgudduucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpefrvght vghrucfgihhsvghnthhrrghuthcuoehpvghtvghrrdgvihhsvghnthhrrghuthesvghnth gvrhhprhhishgvuggsrdgtohhmqeenucggtffrrghtthgvrhhnpeehleffgeegudejteei hfelteduvdeifffhffdvjedvffegjeekudeludehudeifeenucevlhhushhtvghrufhiii gvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehpvghtvghrrdgvihhsvghnthhrrghu thesvghnthgvrhhprhhishgvuggsrdgtohhm X-ME-Proxy: Feedback-ID: i131946ab:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 7 Sep 2022 05:11:38 -0400 (EDT) Message-ID: <316575e0-64b8-3db6-865c-165b94958ce0@enterprisedb.com> Date: Wed, 7 Sep 2022 11:11:37 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.13.0 Subject: Re: [PATCH] Renumber confusing value for GUC_UNIT_BYTE Content-Language: en-US To: Michael Paquier , Tom Lane Cc: Justin Pryzby , Beena Emerson , Andres Freund , pgsql-hackers@postgresql.org References: <20220720145220.GJ12702@telsasoft.com> <5a943ffe-b07d-d99c-b96b-f4ed59c6f3ee@enterprisedb.com> <3052113.1662443873@sss.pgh.pa.us> From: Peter Eisentraut In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On 06.09.22 08:27, Michael Paquier wrote: > On Tue, Sep 06, 2022 at 01:57:53AM -0400, Tom Lane wrote: >> Peter Eisentraut writes: >>> I think renumbering this makes sense. We could just leave the comment >>> as is if we don't come up with a better wording. >> >> +1, I see no need to change the comment. We just need to establish >> the precedent that values within the GUC_UNIT_MEMORY field can be >> chosen sequentially. > > +1. committed without the comment change