From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
cc: Thomas Munro <thomas.munro@enterprisedb.com>,
        pgsql-committers <pgsql-committers@postgresql.org>
Subject: Re: pgsql: Add support for coordinating record typmods among parallel
 worke
In-reply-to: <20170915181436.u6j27rx65giyntmk@alap3.anarazel.de>
References: <E1dsguX-00056N-9x@gemulon.postgresql.org>
 <13971.1505445491@sss.pgh.pa.us>
 <CAEepm=08r6ssWnM7wOAN=omz=s9DHujsJjJY6SN_PTHayPR0hw@mail.gmail.com>
 <14932.1505447120@sss.pgh.pa.us>
 <CAEepm=13KfNVsjzvdz_u4E_3_joAWfL+k6TNaFkr-=WTT_Ou=A@mail.gmail.com>
 <CAEepm=2q2OoJ5K1Mg2_XaqjSSRbMTAmE4V7fsM5O3yTWWkb2aw@mail.gmail.com>
 <29888.1505451575@sss.pgh.pa.us>
 <CAEepm=0y78KA-UFVA=q8joA4m9tPre5y7VxMy2Jzigo+O6E6MA@mail.gmail.com>
 <21075.1505486017@sss.pgh.pa.us>
 <20170915181436.u6j27rx65giyntmk@alap3.anarazel.de>
Comments: In-reply-to Andres Freund <andres@anarazel.de>
	message dated "Fri, 15 Sep 2017 11:14:36 -0700"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <31855.1505502434.1@sss.pgh.pa.us>
Date: Fri, 15 Sep 2017 15:07:14 -0400
Message-ID: <31856.1505502434@sss.pgh.pa.us>
Precedence: bulk
Sender: pgsql-committers-owner@postgresql.org

Andres Freund <andres@anarazel.de> writes:
> On 2017-09-15 10:33:37 -0400, Tom Lane wrote:
>> I don't much like your proposed comment; the only way that this code
>> is even approximately correct is if we're exiting the process and
>> will never touch the RecordCacheArray again.  (Otherwise, it risks
>> reassigning a previously used local typmod.)

> How'd it reuse it after running the detach hook in workers?

Resetting NextRecordTypmod to zero means that we could reuse a typmod
that was previously used.  Maybe that's safe because no memory of the
old record definition exists anywhere else in the process, but I'm
not exactly convinced of that.  For that matter, I'm not exactly
convinced that nothing else is holding on to an actual pointer to the
record tupdesc, making it moot whether or not we flush typcache.c's
pointer.  (I'm pretty sure that plpgsql, for one, might hold onto
tupdesc pointers it gets from the typcache.  That's why they have
refcounts in the first place.)  There's never previously been any
expectation that record typmod registrations weren't good for the life
of the process, so I don't trust any of the assumptions this code
wants to make.

It's moot as long as we're not reusing workers, anyway: nothing is
going to touch any of the record-tupdesc data before process exit.

			regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers