Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n8692-0004E5-At for pgsql-committers@arkaria.postgresql.org; Thu, 13 Jan 2022 19:52:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1n8690-00044q-5G for pgsql-committers@arkaria.postgresql.org; Thu, 13 Jan 2022 19:52:22 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n868z-00044h-LW for pgsql-committers@lists.postgresql.org; Thu, 13 Jan 2022 19:52:21 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1n868s-0007KO-Vb for pgsql-committers@lists.postgresql.org; Thu, 13 Jan 2022 19:52:20 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 20DJqCmu3214612; Thu, 13 Jan 2022 14:52:12 -0500 From: Tom Lane To: Laurenz Albe cc: Michael Paquier , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Improve error handling of cryptohash computations In-reply-to: <9f0c0a96d28cf14fc87296bbe67061c14eb53ae8.camel@cybertec.at> References: <9f0c0a96d28cf14fc87296bbe67061c14eb53ae8.camel@cybertec.at> Comments: In-reply-to Laurenz Albe message dated "Thu, 13 Jan 2022 18:52:19 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3214610.1642103532.1@sss.pgh.pa.us> Date: Thu, 13 Jan 2022 14:52:12 -0500 Message-ID: <3214611.1642103532@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Laurenz Albe writes: > On Tue, 2022-01-11 at 00:56 +0000, Michael Paquier wrote: >> Improve error handling of cryptohash computations > This commit changes the signature of the exported "pg_md5_hash" function, > which breaks my extension that uses this function. > Is there no way to avoid this API break in the back branches? Probably none of this should have been back-patched --- the issues are not so large that they require a risk of breaking things in the back branches. regards, tom lane