Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j0GQj-0005qA-2D for pgsql-committers@arkaria.postgresql.org; Sat, 08 Feb 2020 03:05:13 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1j0GQg-00045S-Q0 for pgsql-committers@arkaria.postgresql.org; Sat, 08 Feb 2020 03:05:10 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.89) (envelope-from ) id 1j0GQg-00041t-Ez for pgsql-committers@lists.postgresql.org; Sat, 08 Feb 2020 03:05:10 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1j0GQZ-0007Lg-GL; Sat, 08 Feb 2020 03:05:08 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id 018350Vn032240; Fri, 7 Feb 2020 22:05:00 -0500 From: Tom Lane To: Fujii Masao cc: Fujii Masao , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix bug in Tid scan. In-reply-to: References: <5261.1581103527@sss.pgh.pa.us> <24554.1581123870@sss.pgh.pa.us> <29908.1581127702@sss.pgh.pa.us> Comments: In-reply-to Fujii Masao message dated "Sat, 08 Feb 2020 11:48:22 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32238.1581131100.1@sss.pgh.pa.us> Date: Fri, 07 Feb 2020 22:05:00 -0500 Message-ID: <32239.1581131100@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Fujii Masao writes: > On Sat, Feb 8, 2020 at 11:08 AM Tom Lane wrote: >> Personally I'd keep SO_TYPE_TIDSCAN physically adjacent to the other >> SO_TYPE_xxxSCAN entries in the list, but of course that's just cosmetic. > +1. So I will apply the latest patch (adding SO_TYPE_TIDSCAN just after > SO_TYPE_ANALYZE) only to v12. Works for me. regards, tom lane