Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f32Rz-0002oi-QH for pgsql-committers@arkaria.postgresql.org; Mon, 02 Apr 2018 16:36:55 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.89) (envelope-from ) id 1f32Ry-0000Z0-QX for pgsql-committers@arkaria.postgresql.org; Mon, 02 Apr 2018 16:36:54 +0000 Received: from makus.postgresql.org ([2001:4800:1501:1::229]) by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f32Ry-0000Yr-Ib for pgsql-committers@lists.postgresql.org; Mon, 02 Apr 2018 16:36:54 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA384:256) (Exim 4.89) (envelope-from ) id 1f32Rw-0005Hm-8h for pgsql-committers@lists.postgresql.org; Mon, 02 Apr 2018 16:36:53 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id w32GaoKk032365; Mon, 2 Apr 2018 12:36:50 -0400 From: Tom Lane To: Peter Eisentraut cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Transforms for jsonb to PL/Python In-reply-to: References: <20d9fdcc-eaec-647a-bf27-e7cc5861547f@2ndquadrant.com> <6087.1522473328@sss.pgh.pa.us> <17960.1522620471@sss.pgh.pa.us> Comments: In-reply-to Peter Eisentraut message dated "Mon, 02 Apr 2018 11:42:18 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <32363.1522687010.1@sss.pgh.pa.us> Date: Mon, 02 Apr 2018 12:36:50 -0400 Message-ID: <32364.1522687010@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Peter Eisentraut writes: > On 4/1/18 18:07, Tom Lane wrote: >> 1. Just remove the tests involving inf/nan. As far as I can see, >> there's no explicit handling of these cases in jsonb_plpython, >> so we're not really buying any test coverage of our own code anyway. > That makes sense. OK, done. regards, tom lane