From: Tom Lane <tgl@sss.pgh.pa.us>
To: Teodor Sigaev <teodor@sigaev.ru>
cc: pgsql-committers@lists.postgresql.org, Fabien COELHO <coelho@cri.ensmp.fr>
Subject: Re: pgsql: Set random seed for pgbench.
In-reply-to: <E1f0U1H-00005J-98@gemulon.postgresql.org>
References: <E1f0U1H-00005J-98@gemulon.postgresql.org>
Comments: In-reply-to Teodor Sigaev <teodor@sigaev.ru>
	message dated "Mon, 26 Mar 2018 15:26:47 -0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <32389.1522464534.1@sss.pgh.pa.us>
Date: Fri, 30 Mar 2018 22:48:54 -0400
Message-ID: <32390.1522464534@sss.pgh.pa.us>
Precedence: bulk

Teodor Sigaev <teodor@sigaev.ru> writes:
> Set random seed for pgbench.

So this patch has ignored the possibility of not having pg_strong_random.
That's moving the portability goalposts in a way that I do not find
acceptable for such a marginal feature.  What behavior do you think we
should have for platforms without that --- accept the seed=rand option
but then error out, or not recognize the option at all?

BTW, I also note that the patch is constructing error messages from
sentence fragments, which is verboten per translatability policy.
While that's perhaps not too important as long as we don't have message
translations for pgbench, it still seems like something to fix now not
later.

			regards, tom lane