Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLEAK-0005as-Ui for pgsql-committers@arkaria.postgresql.org; Fri, 27 Jan 2023 02:08:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pLEAJ-0004JP-SR for pgsql-committers@arkaria.postgresql.org; Fri, 27 Jan 2023 02:08:31 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLEAJ-0004FU-LC for pgsql-committers@lists.postgresql.org; Fri, 27 Jan 2023 02:08:31 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLEAG-0000Sv-Lx for pgsql-committers@lists.postgresql.org; Fri, 27 Jan 2023 02:08:31 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30R28Nl73248937; Thu, 26 Jan 2023 21:08:23 -0500 From: Tom Lane To: Michael Paquier cc: Justin Pryzby , Andrew Dunstan , Robert Haas , Alvaro Herrera , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Adjust interaction of CREATEROLE with role properties. In-reply-to: References: <20230126114659.x3yuypot7p6zj73c@alvherre.pgsql> <25633601-9749-a03c-e1cc-8ff2cf7c599a@dunslane.net> <20230126183106.GS22427@telsasoft.com> Comments: In-reply-to Michael Paquier message dated "Fri, 27 Jan 2023 09:24:37 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3248935.1674785303.1@sss.pgh.pa.us> Date: Thu, 26 Jan 2023 21:08:23 -0500 Message-ID: <3248936.1674785303@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Michael Paquier writes: > On Thu, Jan 26, 2023 at 12:31:06PM -0600, Justin Pryzby wrote: >> On Thu, Jan 26, 2023 at 09:46:07AM -0500, Andrew Dunstan wrote: >>> Would it be worth adding a check right at the end of the schedule that >>> makes sure there are no such roles left? >> Yes, because the alternative is to have cirrus run "installcheck" >> twice.. > Agreed about doing something like that, with a new SQL script perhaps? > We can rely on -DENFORCE_REGRESSION_TEST_NAME_RESTRICTIONS here, and > I'd like to think that nobody creates such role names or they would > see failures with the new query. Yeah ... if we put it into an existing script, somebody will blindly add more tests after it someday. I suggest calling it "test_cleanup" to pair with "test_setup". Is it worth checking for leftover regress_xxx tablespaces as well as roles? regards, tom lane