Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLFG4-0000VI-H3 for pgsql-committers@arkaria.postgresql.org; Fri, 27 Jan 2023 03:18:32 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pLFG3-00012M-Bk for pgsql-committers@arkaria.postgresql.org; Fri, 27 Jan 2023 03:18:31 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLFG3-00012D-4u for pgsql-committers@lists.postgresql.org; Fri, 27 Jan 2023 03:18:31 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLFFv-0000xF-Sn for pgsql-committers@lists.postgresql.org; Fri, 27 Jan 2023 03:18:28 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30R3IJlk3255991; Thu, 26 Jan 2023 22:18:19 -0500 From: Tom Lane To: Michael Paquier cc: Justin Pryzby , Andrew Dunstan , Robert Haas , Alvaro Herrera , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Adjust interaction of CREATEROLE with role properties. In-reply-to: References: <20230126114659.x3yuypot7p6zj73c@alvherre.pgsql> <25633601-9749-a03c-e1cc-8ff2cf7c599a@dunslane.net> <20230126183106.GS22427@telsasoft.com> <3248936.1674785303@sss.pgh.pa.us> Comments: In-reply-to Michael Paquier message dated "Fri, 27 Jan 2023 12:06:02 +0900" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3255989.1674789499.1@sss.pgh.pa.us> Date: Thu, 26 Jan 2023 22:18:19 -0500 Message-ID: <3255990.1674789499@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Michael Paquier writes: > On Thu, Jan 26, 2023 at 09:08:23PM -0500, Tom Lane wrote: >> Is it worth checking for leftover regress_xxx tablespaces as well as >> roles? > Guess so. If this is to be applied to everything that fails under the > naming restrictions, there could be a point in doing the same for > databases, subscriptions and replication origins. Now the argument > has less weight for these object types, surely, compared to roles and > tbspaces. By the time we've spun up a new backend, we might as well do more than one query, so it seems like we might as well check everything that's globally visible. However ... this'd only cover mistakes of this kind in the core regression tests. Is there a way to cover contrib's installcheck (without adding an additional psql run to each module's tests)? Maybe we need to enforce this at some other level than the tests themselves, perhaps in pg_regress? regards, tom lane