From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alexander Korotkov <aekorotkov@gmail.com>
cc: Jeff Davis <pgsql@j-davis.com>, Peter Eisentraut <peter@eisentraut.org>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Make all Perl warnings fatal
In-reply-to: 
 <CAPpHfdv31WnqELu6ZxE6fS-TqtQMAqLA9AWbK3=CvQBokLj_-A@mail.gmail.com>
References: <E1rJGvp-00CWH1-Lj@gemulon.postgresql.org>
 <c2c4a65f9598b05b95d36e5025391892f8408eba.camel@j-davis.com>
 <CAPpHfdv31WnqELu6ZxE6fS-TqtQMAqLA9AWbK3=CvQBokLj_-A@mail.gmail.com>
Comments: In-reply-to Alexander Korotkov <aekorotkov@gmail.com>
	message dated "Sat, 30 Dec 2023 00:17:22 +0200"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3261738.1703889716.1@sss.pgh.pa.us>
Content-Transfer-Encoding: 8bit
Date: Fri, 29 Dec 2023 17:41:56 -0500
Message-ID: <3261739.1703889716@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3261739.1703889716%40sss.pgh.pa.us>
Precedence: bulk

Alexander Korotkov <aekorotkov@gmail.com> writes:
> On Fri, Dec 29, 2023 at 10:13 PM Jeff Davis <pgsql@j-davis.com> wrote:
>> This seems to be causing problems in the buildfarm:
>> Use of uninitialized value $ENV{"PG_TEST_EXTRA"} in pattern match
>> (m//) at t/001_mutated_bindpasswd.pl line 23.

> It seems to cause failures for many buildfarm machines.

Presumably, exactly the ones that don't set PG_TEST_EXTRA :-(.
Peter would not have noticed this if he keeps that set in his
test environment.

The fix looks simple enough, although a bit tedious because there
are a bunch of places to change.  I can have a go at it if no-one
else is already on it?

			regards, tom lane