Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYpIy-0002xn-PZ for pgsql-committers@arkaria.postgresql.org; Thu, 15 Sep 2022 13:53:24 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oYpIx-00058N-Lh for pgsql-committers@arkaria.postgresql.org; Thu, 15 Sep 2022 13:53:23 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYpIx-00058E-Ex for pgsql-committers@lists.postgresql.org; Thu, 15 Sep 2022 13:53:23 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oYpIt-00025L-Ge for pgsql-committers@lists.postgresql.org; Thu, 15 Sep 2022 13:53:22 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 28FDrEQv3264634; Thu, 15 Sep 2022 09:53:14 -0400 From: Tom Lane To: Bharath Rupireddy cc: Alvaro Herrera , Andrew Dunstan , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Use the terminology "WAL file" not "log file" more consistently. In-reply-to: References: <3122568.1663217302@sss.pgh.pa.us> <20220915092420.5helrihxjx3hzqid@alvherre.pgsql> Comments: In-reply-to Bharath Rupireddy message dated "Thu, 15 Sep 2022 15:49:25 +0530" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3264632.1663249994.1@sss.pgh.pa.us> Date: Thu, 15 Sep 2022 09:53:14 -0400 Message-ID: <3264633.1663249994@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Bharath Rupireddy writes: > Thanks for pointing it out. It seems like a good idea IMO. I think > pg_resetwal also needs the --machine approach. As --machine approach > needs a good amount of refactoring and discussion, I still think we > can make buildfarm happy by fixing a proposed solution [1]. Perhaps, > we can start a new thread for --machine approach. Agreed; here on -committers is certainly no place for that. For the moment I'm just going to revert the change in pg_controldata output, because it occurred to me that pg_upgrade might not be the only tool side-swiped by that. We can put it back after we have some more-stable output format that such tools can start using. regards, tom lane