Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncSa8-0000qx-6j for pgsql-committers@arkaria.postgresql.org; Thu, 07 Apr 2022 13:53:52 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ncSa6-0003Qy-4a for pgsql-committers@arkaria.postgresql.org; Thu, 07 Apr 2022 13:53:50 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncSa5-0003Qp-Tm for pgsql-committers@lists.postgresql.org; Thu, 07 Apr 2022 13:53:49 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncSa3-0001l3-Nv; Thu, 07 Apr 2022 13:53:49 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 237DrhmX3279391; Thu, 7 Apr 2022 09:53:43 -0400 From: Tom Lane To: Andrew Dunstan cc: Andres Freund , Thomas Munro , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Prefetch data referenced by the WAL, take II. In-reply-to: References: <20220407083630.n62vgwqfy2v6wsrd@alap3.anarazel.de> Comments: In-reply-to Andrew Dunstan message dated "Thu, 07 Apr 2022 08:18:05 -0400" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3279389.1649339623.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 07 Apr 2022 09:53:43 -0400 Message-ID: <3279390.1649339623@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > On 4/7/22 04:36, Andres Freund wrote: >> Or maybe it's the scripts that are screwed up? Because I don't see any = error >> checking in headerscheck/cpluspluscheck. And indeed, locally they show = the >> errors, but exit with 0. > Yeah, you can't rely on the exit status, if they produce output that > should be regarded as a failure (that's what crake does). Yeah, those scripts were only intended to be run by hand. If someone feels like upgrading them to also produce a useful exit status, I'm for it. regards, tom lane