Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1CUQ-0006Ad-Hp for pgsql-committers@arkaria.postgresql.org; Fri, 02 Dec 2022 20:18:30 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1p1CUP-0006Rb-1Q for pgsql-committers@arkaria.postgresql.org; Fri, 02 Dec 2022 20:18:29 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p1CUO-0006RP-QW for pgsql-committers@lists.postgresql.org; Fri, 02 Dec 2022 20:18:28 +0000 Received: from mail-pj1-x102f.google.com ([2607:f8b0:4864:20::102f]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.92) (envelope-from ) id 1p1CUK-00032f-Vd for pgsql-committers@lists.postgresql.org; Fri, 02 Dec 2022 20:18:27 +0000 Received: by mail-pj1-x102f.google.com with SMTP id b13-20020a17090a5a0d00b0021906102d05so6094452pjd.5 for ; Fri, 02 Dec 2022 12:18:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=j-davis-com.20210112.gappssmtp.com; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:from:to:cc:subject:date :message-id:reply-to; bh=xn2kW8fgsdWKyUjFmoxIs+9BjOo0zo4RwKYwMKYzl/w=; b=Yh0pU160XUM01faNb7qEuUMoOgE68xq6Z7YRJaYWIdPIj3G91rW52tNO3G28/abeph o+OZHRkj3L3ID87HGiHq6hEwFMye4NS36bFCtcYLUf1SICLQHO6V4ihtoULjqul8Ilrv CNSwW+N/rvUWlxbVRedN5kZtl/8ZHABZ9mKpb/iQFrFxeg6H6B+AaFlaVSFsmJh0A13q jOn5nhUEhv/MGKfEm0hSD7wCe9XbMc/Z4nqvzAFnovkSsiqkDtWtJUVzZ9vKgv64DD1m T+VVUN8MvaclcOd142tieS0olroIXOZet0AWoVDInvpLUNuZHeNRtES3CaL54KtCJW+Q Kp/g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:to:from:subject:message-id:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=xn2kW8fgsdWKyUjFmoxIs+9BjOo0zo4RwKYwMKYzl/w=; b=oejWxLo2iqlVgwWa+aExrBKoEPej8M+60NRu5Yj+rQC6E+YPn/llfQt4TO+uRvSenU okTBnNzf33zty5MSvovKCrwMSphdivPZYDl7NpmaHQBgZBTgzqoQQ4tYVxUduc1WiqT4 0nINjXD6O9pt8BocFgzeeWiz8BJeeKt2sPNlQQAA+TJPdi9BVXcndSn0PchoqFh0Rb9a 6DIVqCCmbgwmD4kVD8xJDzYjnb3U8CXF4jshgSL7W859xKwOnvH965PWVrW5/5froX/A Z8gtYLMBNCbPukvpv+rbHBQEfEyvx0c8RFNqCBEaAUuqkWB+JIfKXgwhyqN4yXrPxpMx Px+Q== X-Gm-Message-State: ANoB5pkZfeJypCskv72qKftLavyKjtrvYYQ6SoUZmE4sO5Pd3Ocf4MJF PGyMvYwmpWR4O0K/WzvBjDBTnJSmkR6odRcS X-Google-Smtp-Source: AA0mqf7qHKMpN0ZXkCEsE34YGVAgxt6VCtQuze0/pgue+bydL6hHJrckfqO1NLn9XAiAoY26B+dYIw== X-Received: by 2002:a17:902:da82:b0:189:adf8:54f8 with SMTP id j2-20020a170902da8200b00189adf854f8mr12916547plx.81.1670012303952; Fri, 02 Dec 2022 12:18:23 -0800 (PST) Received: from jeff-laptop.lan (c-73-231-146-4.hsd1.ca.comcast.net. [73.231.146.4]) by smtp.gmail.com with ESMTPSA id q19-20020aa79613000000b00562a526cd2esm5492275pfg.55.2022.12.02.12.18.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 02 Dec 2022 12:18:23 -0800 (PST) Message-ID: <32a9b8357e8e29b04f395f92c53b64e015a4caf1.camel@j-davis.com> Subject: Re: pgsql: Doc: document bpchar, clarify relationship of text and varchar. From: Jeff Davis To: Tom Lane , pgsql-committers@lists.postgresql.org Date: Fri, 02 Dec 2022 12:18:22 -0800 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4-0ubuntu1 MIME-Version: 1.0 List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk On Wed, 2022-09-28 at 16:31 +0000, Tom Lane wrote: > Doc: document bpchar, clarify relationship of text and varchar. BPCHAR is documented as an alias to CHARACTER, but the former can end up with no typmod at all whereas the latter defaults to CHARACTER(1). Should we document the case of using BPCHAR with no length? I noticed this because there exists a hash function bug[1] that seems to be visible with BPCHAR but not CHARACTER. [1] https://www.postgresql.org/message-id/7692740d4736e79032a5dac689cf2e304c03f= a78.camel@j-davis.com --=20 Jeff Davis PostgreSQL Contributor Team - AWS