To: Andrew Dunstan <andrew@dunslane.net>
cc: pgsql-hackers@postgresql.org
Subject: Re: Re: [COMMITTERS] pgsql: Initialise perl library as documented in
	perl API.
In-reply-to: <4A292199.6030201@dunslane.net> 
References: <20090604155955.545F775331E@cvs.postgresql.org>
	<26709.1244133504@sss.pgh.pa.us> <4A27FF9E.50305@dunslane.net>
	<1340.1244136781@sss.pgh.pa.us> <4A280AEC.8090007@dunslane.net>
	<4A292199.6030201@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Fri, 05 Jun 2009 09:46:01 -0400"
Date: Fri, 05 Jun 2009 10:03:25 -0400
Message-ID: <3310.1244210605@sss.pgh.pa.us>
From: Tom Lane <tgl@sss.pgh.pa.us>

Andrew Dunstan <andrew@dunslane.net> writes:
> I think we need to float a bug upstream to the perl guys on this, but as 
> a holding position I suggest that we alter the #ifdef test to avoid 
> calling PERL_SYS_INIT3() where MYMALLOC is defined.

+1 on both.

> BTW, it's not caused by passing NULL as the third argument of 
> PERL_SYS_INIT3() - changing that was the first thing I tried.

Nonetheless, that compiler warning is pretty ugly; please do something
about it.  I concur with your feeling that setting up a dummy empty
environment array is probably the safest thing to do.

			regards, tom lane