Content-Type: text/plain;
	charset=us-ascii
Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3774.500.171.1.1\))
Subject: Re: pgsql: Fix compilation on OpenSSL 1.0.2 and LibreSSL
From: Daniel Gustafsson <daniel@yesql.se>
In-Reply-To: <6f62a93d-3ebb-476f-8ff2-1187c790cd99@iki.fi>
Date: Fri, 3 May 2024 10:44:39 +0200
Cc: Heikki Linnakangas <heikki.linnakangas@iki.fi>,
 pgsql-committers@lists.postgresql.org
Content-Transfer-Encoding: quoted-printable
Message-Id: <331BA556-4AAD-4B09-B86B-A5947F248E3F@yesql.se>
References: <E1s1g0Z-000jeC-OR@gemulon.postgresql.org>
 <1C71E5C4-46BE-46B7-9884-310B25280B49@yesql.se>
 <5f162ff7-02f0-42f4-9473-53cfb7393bc3@iki.fi>
 <5EACEB09-BCBC-432A-A5B0-E8FD73808276@yesql.se>
 <6f62a93d-3ebb-476f-8ff2-1187c790cd99@iki.fi>
To: Heikki Linnakangas <hlinnaka@iki.fi>
Archived-At: 
 <https://www.postgresql.org/message-id/331BA556-4AAD-4B09-B86B-A5947F248E3F%40yesql.se>
Precedence: bulk

> On 2 May 2024, at 12:30, Heikki Linnakangas <hlinnaka@iki.fi> wrote:
> On 02/05/2024 13:24, Daniel Gustafsson wrote:

>> This makes targeting 7.0 as the lowest LibreSSL version appealing in =
my
>> patchset for removing support for old OpenSSL and LibreSSL versions.
>=20
> Works for me. Although there's little harm in keeping the "#ifdef =
SSL_AD_NO_APPLICATION_PROTOCOL" either, if that's the only thing missing =
from 6.9.

In the meantime I'll apply the below to keep the comment correct and to =
help
future-me when revisiting SSL library support =3D)

-        * OpenSSL 1.1.0 and later, but as of this writing not in =
LibreSSL.
+        * OpenSSL 1.1.0 and later, as well as in LibreSSL 3.4.3 =
(OpenBSD 7.0) and
+        * later.

Any objections to that?

--
Daniel Gustafsson