Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKMw8-0000li-Ct for pgsql-committers@arkaria.postgresql.org; Wed, 16 Feb 2022 16:13:48 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1nKMw7-0005g3-AY for pgsql-committers@arkaria.postgresql.org; Wed, 16 Feb 2022 16:13:47 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKMw7-0005ft-3c for pgsql-committers@lists.postgresql.org; Wed, 16 Feb 2022 16:13:47 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nKMw0-0000gP-Jo for pgsql-committers@lists.postgresql.org; Wed, 16 Feb 2022 16:13:46 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 21GGDZ2N3323701; Wed, 16 Feb 2022 11:13:35 -0500 From: Tom Lane To: Peter Eisentraut cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Remove IS_AF_UNIX macro In-reply-to: <2c53ab2c-e14d-eb00-554e-5520bdbc8d3c@enterprisedb.com> References: <3047303.1644939704@sss.pgh.pa.us> <2c53ab2c-e14d-eb00-554e-5520bdbc8d3c@enterprisedb.com> Comments: In-reply-to Peter Eisentraut message dated "Wed, 16 Feb 2022 17:06:12 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3323699.1645028015.1@sss.pgh.pa.us> Date: Wed, 16 Feb 2022 11:13:35 -0500 Message-ID: <3323700.1645028015@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > On 15.02.22 16:41, Tom Lane wrote: >> I hadn't looked closely at this patch, but are you referring to >> this bit in ip.h? > In src/backend/utils/adt/pgstatfuncs.c there is a use of AF_UNIX that > has been there unprotected by any #ifdef since about 2008. Oh, I see it :-(. Poor coding, but it evidently no longer matters. > Maybe/probably. But there is a difference between platforms having the > AF_UNIX symbol (which is required by POSIX unconditionally) and > platforms actually having Unix sockets or not (which might require > different default configurations or run-time behavior), so the two > questions are not that closely connected. Fair point. regards, tom lane