Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLQwP-0002TG-G5 for pgsql-committers@arkaria.postgresql.org; Fri, 27 Jan 2023 15:47:01 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pLQwO-0004wN-5I for pgsql-committers@arkaria.postgresql.org; Fri, 27 Jan 2023 15:47:00 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLQwN-0004wE-UQ for pgsql-committers@lists.postgresql.org; Fri, 27 Jan 2023 15:46:59 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pLQwL-0007je-Nd for pgsql-committers@lists.postgresql.org; Fri, 27 Jan 2023 15:46:58 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30RFkrSk3332371; Fri, 27 Jan 2023 10:46:53 -0500 From: Tom Lane To: Justin Pryzby cc: Andrew Dunstan , Michael Paquier , Robert Haas , Alvaro Herrera , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Adjust interaction of CREATEROLE with role properties. In-reply-to: <20230127152854.GY22427@telsasoft.com> References: <20230126114659.x3yuypot7p6zj73c@alvherre.pgsql> <25633601-9749-a03c-e1cc-8ff2cf7c599a@dunslane.net> <20230126183106.GS22427@telsasoft.com> <3248936.1674785303@sss.pgh.pa.us> <3255990.1674789499@sss.pgh.pa.us> <6c20449e-ac9c-7876-0d90-70a1ddea1076@dunslane.net> <20230127152854.GY22427@telsasoft.com> Comments: In-reply-to Justin Pryzby message dated "Fri, 27 Jan 2023 09:28:54 -0600" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3332369.1674834413.1@sss.pgh.pa.us> Date: Fri, 27 Jan 2023 10:46:53 -0500 Message-ID: <3332370.1674834413@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Justin Pryzby writes: > On Fri, Jan 27, 2023 at 08:27:40AM -0500, Andrew Dunstan wrote: >> On 2023-01-26 Th 22:18, Tom Lane wrote: >>> Maybe we need to enforce this at some other level than the tests >>> themselves, perhaps in pg_regress? >> Yeah, that seems like a better way to go. Then it would even apply to >> external project tests. > Maybe this could be done by creating a pg_dump ? That'd be an amazingly expensive way to do it. I was imagining that pg_regress could contain a function that issues some predefined queries and complains if the results aren't empty. It already has the ability to issue commands to the cluster-under-test (for the initial CREATE DATABASE etc) so at least most of the infrastructure is easily at hand. regards, tom lane