Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncWOL-0006pO-3F for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Apr 2022 17:57:57 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ncWOJ-0008SO-OG for pgsql-hackers@arkaria.postgresql.org; Thu, 07 Apr 2022 17:57:55 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncWOJ-0008SE-FP for pgsql-hackers@lists.postgresql.org; Thu, 07 Apr 2022 17:57:55 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ncWOD-0004mH-Dc for pgsql-hackers@lists.postgresql.org; Thu, 07 Apr 2022 17:57:55 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 237HvjVN3386735; Thu, 7 Apr 2022 13:57:45 -0400 From: Tom Lane To: Andres Freund cc: Michael Paquier , pgsql-hackers@lists.postgresql.org Subject: Re: pgsql: Add TAP test for archive_cleanup_command and recovery_end_comman In-reply-to: <20220407175210.q44nnrvkovprxo2a@alap3.anarazel.de> References: <3385143.1649353230@sss.pgh.pa.us> <20220407175210.q44nnrvkovprxo2a@alap3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Thu, 07 Apr 2022 10:52:10 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3386733.1649354265.1@sss.pgh.pa.us> Date: Thu, 07 Apr 2022 13:57:45 -0400 Message-ID: <3386734.1649354265@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2022-04-07 13:40:30 -0400, Tom Lane wrote: >> This test is sending a CHECKPOINT command to the standby and >> expecting it to run the archive_cleanup_command, but it looks >> like the standby did not actually run any checkpoint: >> ... >> I wondered if the recent pg_stats changes could have affected this, but I >> don't really see how. > I don't really see either. It's a bit more conceivable that the recovery > prefetching changes could affect the timing sufficiently? Oh, that's at least a little plausible. > I guess we'll have to wait and see what the frequency of the problem is? Yeah, with only one instance it could just be cosmic rays or something. However, assuming it is real, I guess I wonder why we don't say CHECKPOINT_FORCE in standby mode too. regards, tom lane