Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mobYo-0007BN-QT for pgsql-committers@arkaria.postgresql.org; Sun, 21 Nov 2021 01:22:26 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mobYn-0008UD-Jr for pgsql-committers@arkaria.postgresql.org; Sun, 21 Nov 2021 01:22:25 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mobYn-0008U4-Ci for pgsql-committers@lists.postgresql.org; Sun, 21 Nov 2021 01:22:25 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mobYg-0008N1-Ku for pgsql-committers@lists.postgresql.org; Sun, 21 Nov 2021 01:22:24 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 1AL1MEDD3386969; Sat, 20 Nov 2021 20:22:14 -0500 From: Tom Lane To: Noah Misch cc: Andrew Dunstan , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Require version 0.98 of Test::More for TAP tests In-reply-to: <20211121011026.GB1362012@rfd.leadboat.com> References: <3369543.1637454364@sss.pgh.pa.us> <3369927.1637454743@sss.pgh.pa.us> <20211121003630.GA1362012@rfd.leadboat.com> <3371085.1637455802@sss.pgh.pa.us> <20211121011026.GB1362012@rfd.leadboat.com> Comments: In-reply-to Noah Misch message dated "Sat, 20 Nov 2021 17:10:26 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3386967.1637457734.1@sss.pgh.pa.us> Date: Sat, 20 Nov 2021 20:22:14 -0500 Message-ID: <3386968.1637457734@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Noah Misch writes: > On Sat, Nov 20, 2021 at 07:50:02PM -0500, Tom Lane wrote: >> What I'm inclined to do is temporarily push `dirname $PERL` onto the front >> of PATH while running >> PGAC_PATH_PROGS(PROVE, prove) > Adding to PATH, even briefly, is way too brazen. You'd need to be sure that > PATH is never searched for anything other than "prove", which is hard to > ensure in a shell script. Hmm. I kind of doubt that anyone would be selecting a perl in an untrustworthy directory --- wouldn't that imply that $blackhat could overwrite perl itself? Still, it wouldn't be that much more trouble to write something like if [ -x "`dirname "$PERL"`/prove" ]; then PROVE="`dirname "$PERL"`/prove" else PGAC_PATH_PROGS(PROVE, prove) fi (this lacks some infrastructure, but you get the point). > I'd be -1 on a back-patch and -0.7 for HEAD. I think we need a back-patch of *something*. It's pure luck that wrasse hasn't shown problems already. I don't want to be rediscovering this issue a year from now when somebody back-patches some test requiring subtests. regards, tom lane