Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moc4g-0000bs-2H for pgsql-committers@arkaria.postgresql.org; Sun, 21 Nov 2021 01:55:22 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1moc4f-0006wR-0F for pgsql-committers@arkaria.postgresql.org; Sun, 21 Nov 2021 01:55:21 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moc4e-0006wI-PM for pgsql-committers@lists.postgresql.org; Sun, 21 Nov 2021 01:55:20 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1moc4c-0000Dw-11 for pgsql-committers@lists.postgresql.org; Sun, 21 Nov 2021 01:55:20 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 1AL1tCC03389296; Sat, 20 Nov 2021 20:55:12 -0500 From: Tom Lane To: Noah Misch cc: Andrew Dunstan , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Require version 0.98 of Test::More for TAP tests In-reply-to: <20211121013715.GC1362012@rfd.leadboat.com> References: <3369543.1637454364@sss.pgh.pa.us> <3369927.1637454743@sss.pgh.pa.us> <20211121003630.GA1362012@rfd.leadboat.com> <3371085.1637455802@sss.pgh.pa.us> <20211121011026.GB1362012@rfd.leadboat.com> <3386968.1637457734@sss.pgh.pa.us> <20211121013715.GC1362012@rfd.leadboat.com> Comments: In-reply-to Noah Misch message dated "Sat, 20 Nov 2021 17:37:15 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3389294.1637459712.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 20 Nov 2021 20:55:12 -0500 Message-ID: <3389295.1637459712@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Noah Misch writes: > On Sat, Nov 20, 2021 at 08:22:14PM -0500, Tom Lane wrote: >> I think we need a back-patch of *something*. It's pure luck that wrass= e >> hasn't shown problems already. I don't want to be rediscovering this >> issue a year from now when somebody back-patches some test requiring >> subtests. > If you want to allow subtests in all branches, $SUBJECT is the thing nee= ding a > back-patch. Agreed, but I think we're going to want to do that as soon as the dust has settled. We have plenty of precedent for back-patching test infrastructure, and I don't see why this wouldn't qualify. > By default, they remain banned in back-patches. They're banned only in the sense that one or two old, slow buildfarm animals will fail on them; the odds that anyone would notice the problem before a patch reaches the buildfarm seem poor. I'd just as soon not set that trap for ourselves. It's not like we expect testing with obsolete Perl modules to be much of a concern in non-buildfarm usage, even for consumers of back branches. I also note that prairiedog will soon not be in the camp that fails, even for back branches. Neither will wrasse unless you invent some truly strange configuration trick for it. So the argument that there's a back-branch ban on subtests doesn't seem like it will have much enforcement behind it. regards, tom lane