Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pl9KV-00078w-NA for pgsql-committers@arkaria.postgresql.org; Sat, 08 Apr 2023 14:14:11 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pl9KU-00015A-FJ for pgsql-committers@arkaria.postgresql.org; Sat, 08 Apr 2023 14:14:10 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pl9KU-000151-89 for pgsql-committers@lists.postgresql.org; Sat, 08 Apr 2023 14:14:10 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1pl9KR-001eHl-L6 for pgsql-committers@lists.postgresql.org; Sat, 08 Apr 2023 14:14:09 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 338EE4in3389657; Sat, 8 Apr 2023 10:14:04 -0400 From: Tom Lane To: Andrew Dunstan cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Try to unbreak MSVC builds for fuzzystrmatch In-reply-to: References: Comments: In-reply-to Andrew Dunstan message dated "Sat, 08 Apr 2023 12:28:58 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3389655.1680963244.1@sss.pgh.pa.us> Date: Sat, 08 Apr 2023 10:14:04 -0400 Message-ID: <3389656.1680963244@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > Try to unbreak MSVC builds for fuzzystrmatch > Commit a290378a37 neglrected to add a recipe for MSVC to build the > daitch_motokoff.h file. Oh! Thank you. I'd even made a mental note yesterday "what about MSVC" and then forgot it by the time I'd finished reviewing other aspects of that patch. regards, tom lane