Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mopCd-0007s2-P5 for pgsql-committers@arkaria.postgresql.org; Sun, 21 Nov 2021 15:56:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mopC6-00082R-85 for pgsql-committers@arkaria.postgresql.org; Sun, 21 Nov 2021 15:55:54 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mopC6-00082I-0u for pgsql-committers@lists.postgresql.org; Sun, 21 Nov 2021 15:55:54 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mopBz-0007Bn-Om for pgsql-committers@lists.postgresql.org; Sun, 21 Nov 2021 15:55:53 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 1ALFtgsx3441610; Sun, 21 Nov 2021 10:55:42 -0500 From: Tom Lane To: Andrew Dunstan cc: Noah Misch , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Require version 0.98 of Test::More for TAP tests In-reply-to: <57050e42-7717-3131-1704-80ce0ad4a9f2@dunslane.net> References: <3369543.1637454364@sss.pgh.pa.us> <3369927.1637454743@sss.pgh.pa.us> <20211121003630.GA1362012@rfd.leadboat.com> <3371085.1637455802@sss.pgh.pa.us> <20211121011026.GB1362012@rfd.leadboat.com> <57050e42-7717-3131-1704-80ce0ad4a9f2@dunslane.net> Comments: In-reply-to Andrew Dunstan message dated "Sun, 21 Nov 2021 09:02:49 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3441608.1637510142.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sun, 21 Nov 2021 10:55:42 -0500 Message-ID: <3441609.1637510142@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andrew Dunstan writes: > On 11/20/21 20:10, Noah Misch wrote: >> The skip would be unnecessary if configure just tested whether $PROVE c= an run >> a test requiring the module. We're testing $PERL, but we're actually >> indifferent to $PERL's Test::More. > Yeah, we could do something along these lines: > [ script ] Seems reasonable to me, although it's not entirely clear how to hook the output into configure's practices --- in particular, people using "./configure -q" might not be pleased by unwanted diagnostic output. But that could probably be dealt with. > prove is pretty much always a script - if we want to know which perl is > invoked we could look at its shebang line. Do we care though? I think the $64 question is whether it's a great idea to run the TAP tests with a different Perl than is used for (a) build tooling and (b) building plperl against. I guess that it should work in principle, and the msys animals apparently need it, but I'm concerned that somebody will waste a lot of time being confused by unexpected behavioral differences. ("This works when I run a perl script by hand, why doesn't it work in my TAP test?") So I still think that the best default behavior is to pick a prove associated with the selected perl, and if you really want something other than that then you have to set PROVE explicitly. IOW, I think we should make (and back-patch) both of the changes discussed in this thread. regards, tom lane