Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEAo7-0007Ua-9p for pgsql-committers@arkaria.postgresql.org; Sat, 07 Jan 2023 15:08:27 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pEAo4-00083W-Ed for pgsql-committers@arkaria.postgresql.org; Sat, 07 Jan 2023 15:08:24 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEAo4-000827-7J for pgsql-committers@lists.postgresql.org; Sat, 07 Jan 2023 15:08:24 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pEAo0-0005q5-4F for pgsql-committers@lists.postgresql.org; Sat, 07 Jan 2023 15:08:22 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 307F8HDw3446330; Sat, 7 Jan 2023 10:08:17 -0500 From: Tom Lane To: David Rowley cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Fix calculation of which GENERATED columns need to be updated. In-reply-to: References: Comments: In-reply-to David Rowley message dated "Sat, 07 Jan 2023 23:42:41 +1300" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3446328.1673104097.1@sss.pgh.pa.us> Date: Sat, 07 Jan 2023 10:08:17 -0500 Message-ID: <3446329.1673104097@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk David Rowley writes: > On Fri, 6 Jan 2023 at 08:12, Tom Lane wrote: >> Fix calculation of which GENERATED columns need to be updated. >> src/backend/nodes/outfuncs.c | 1 - >> src/backend/nodes/readfuncs.c | 1 - > Is this missing a cat version bump? ... Ugh, you're right, I should have done one in HEAD. Probably too late to be useful now. regards, tom lane