Received: from malur.postgresql.org ([217.196.149.56])
	by arkaria.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1ifPXG-0001hr-4e
	for pgsql-committers@arkaria.postgresql.org; Thu, 12 Dec 2019 14:33:46 +0000
Received: from localhost ([127.0.0.1] helo=malur.postgresql.org)
	by malur.postgresql.org with esmtp (Exim 4.89)
	(envelope-from <pgsql-committers-owner+archive@lists.postgresql.org>)
	id 1ifPXE-0003q6-Pl
	for pgsql-committers@arkaria.postgresql.org; Thu, 12 Dec 2019 14:33:44 +0000
Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29])
	by malur.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ifPXE-0003py-I5
	for pgsql-committers@lists.postgresql.org; Thu, 12 Dec 2019 14:33:44 +0000
Received: from sss.pgh.pa.us ([66.207.139.130])
	by magus.postgresql.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_CBC_SHA1:256)
	(Exim 4.89)
	(envelope-from <tgl@sss.pgh.pa.us>)
	id 1ifPXB-0006Xt-QU
	for pgsql-committers@lists.postgresql.org; Thu, 12 Dec 2019 14:33:44 +0000
Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1])
	by sss.pgh.pa.us (8.14.4/8.14.4) with ESMTP id xBCEXbqO003563;
	Thu, 12 Dec 2019 09:33:37 -0500
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Alvaro Herrera <alvherre@alvh.no-ip.org>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Emit parameter values during query bind/execute errors
In-reply-to: <E1if9CT-0001Wg-LF@gemulon.postgresql.org>
References: <E1if9CT-0001Wg-LF@gemulon.postgresql.org>
Comments: In-reply-to Alvaro Herrera <alvherre@alvh.no-ip.org>
	message dated "Wed, 11 Dec 2019 21:07:13 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3561.1576161217.1@sss.pgh.pa.us>
Date: Thu, 12 Dec 2019 09:33:37 -0500
Message-ID: <3562.1576161217@sss.pgh.pa.us>
List-Id: <pgsql-committers.lists.postgresql.org>
List-Help: <https://lists.postgresql.org/manage/>
List-Subscribe: <https://lists.postgresql.org/manage/>
List-Post: <mailto:pgsql-committers@lists.postgresql.org>
List-Owner: <mailto:pgsql-committers-owner@lists.postgresql.org>
List-Archive: <https://www.postgresql.org/list/pgsql-committers>
Precedence: bulk

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Emit parameter values during query bind/execute errors

(Some of?) the Windows buildfarm critters don't like the test
case you added.  I speculate that the test pattern is neglecting
to allow for Windows-style newlines.

			regards, tom lane