Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqSS1-0003zl-CQ for pgsql-committers@arkaria.postgresql.org; Fri, 26 Nov 2021 04:03:05 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1mqSRy-0003fb-Mb for pgsql-committers@arkaria.postgresql.org; Fri, 26 Nov 2021 04:03:02 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqSRy-0003fS-EO for pgsql-committers@lists.postgresql.org; Fri, 26 Nov 2021 04:03:02 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqSRr-00084j-KY for pgsql-committers@lists.postgresql.org; Fri, 26 Nov 2021 04:03:01 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 1AQ42n9s359622; Thu, 25 Nov 2021 23:02:49 -0500 From: Tom Lane To: Robert Haas cc: Andres Freund , pgsql-committers Subject: Re: pgsql: xlog.c: Remove global variables ReadRecPtr and EndRecPtr. In-reply-to: References: <20211124231206.gbadj5bblcljb6d5@alap3.anarazel.de> <20211125010145.fqt4mlkhzyiz4wvw@alap3.anarazel.de> Comments: In-reply-to Robert Haas message dated "Thu, 25 Nov 2021 20:30:48 -0500" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <359620.1637899369.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Thu, 25 Nov 2021 23:02:49 -0500 Message-ID: <359621.1637899369@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Robert Haas writes: > On Wed, Nov 24, 2021 at 8:01 PM Andres Freund wrote= : >> Pushed the obvious fix for that. Somehow thought I'd seen more compile = failure >> than the one WAL_DEBUG... > Hmm, thanks. I guess i put too much trust in the compiler. My approach to such patches is always "in grep we trust, all others pay cash". Even without #ifdef issues, you are highly likely to miss comments that need to be updated. regards, tom lane