Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plCkz-0000ue-4a for pgsql-committers@arkaria.postgresql.org; Sat, 08 Apr 2023 17:53:45 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1plCkx-0006vF-Vg for pgsql-committers@arkaria.postgresql.org; Sat, 08 Apr 2023 17:53:43 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1plCkx-0006v6-ON for pgsql-committers@lists.postgresql.org; Sat, 08 Apr 2023 17:53:43 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1plCkr-001g0s-1f for pgsql-committers@lists.postgresql.org; Sat, 08 Apr 2023 17:53:43 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 338HrYfU3598665; Sat, 8 Apr 2023 13:53:34 -0400 From: Tom Lane To: Peter Geoghegan cc: Andrew Dunstan , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Try to unbreak MSVC builds for pg_waldump In-reply-to: References: Comments: In-reply-to Peter Geoghegan message dated "Sat, 08 Apr 2023 10:44:10 -0700" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3598663.1680976414.1@sss.pgh.pa.us> Date: Sat, 08 Apr 2023 13:53:34 -0400 Message-ID: <3598664.1680976414@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Geoghegan writes: > I was under the impression that issues like this would be caught by > CI. We used to have an MSVC CI target, but that's no longer the case > -- not since commit e6b6ea02. I'll need to remember that. I thought we were planning to drop the MSVC build scripts for v16. Is that no longer happening? If they're going to be around for awhile, maybe that CI job needs to be resurrected. regards, tom lane