Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ky76P-0004i2-Ba for pgsql-committers@arkaria.postgresql.org; Sat, 09 Jan 2021 05:47:53 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1ky76M-00037G-Vz for pgsql-committers@arkaria.postgresql.org; Sat, 09 Jan 2021 05:47:50 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ky76M-000379-Qm for pgsql-committers@lists.postgresql.org; Sat, 09 Jan 2021 05:47:50 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ky76K-0005mN-Et; Sat, 09 Jan 2021 05:47:49 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 1095llXG363513; Sat, 9 Jan 2021 00:47:47 -0500 From: Tom Lane To: Amit Kapila cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Test decoding of two-phase transactions during the build of a co In-reply-to: References: Comments: In-reply-to Amit Kapila message dated "Tue, 05 Jan 2021 09:36:46 +0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <363511.1610171267.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Sat, 09 Jan 2021 00:47:47 -0500 Message-ID: <363512.1610171267@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Precedence: bulk Amit Kapila writes: > Test decoding of two-phase transactions during the build of a consistent= snapshot. It seems this test case isn't 100% stable: https://buildfarm.postgresql.org/cgi-bin/show_log.pl?nm=3Dchipmunk&dt=3D20= 21-01-08%2023%3A56%3A57 =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D output_iso/regression.diffs =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D diff -U3 /home/pgbfarm/buildroot/HEAD/pgsql.build/contrib/test_decoding/ex= pected/twophase_snapshot.out /home/pgbfarm/buildroot/HEAD/pgsql.build/cont= rib/test_decoding/output_iso/results/twophase_snapshot.out --- /home/pgbfarm/buildroot/HEAD/pgsql.build/contrib/test_decoding/expecte= d/twophase_snapshot.out 2021-01-07 02:49:30.231809843 +0200 +++ /home/pgbfarm/buildroot/HEAD/pgsql.build/contrib/test_decoding/output_= iso/results/twophase_snapshot.out 2021-01-09 04:01:26.730510078 +0200 @@ -26,6 +26,8 @@ data = = BEGIN = +COMMIT = +BEGIN = table public.do_write: INSERT: id[integer]:2 COMMIT = step s2cp: COMMIT PREPARED 'test1'; @@ -33,6 +35,10 @@ data = = BEGIN = +COMMIT = +BEGIN = +COMMIT = +BEGIN = table public.do_write: INSERT: id[integer]:1 PREPARE TRANSACTION 'test1' COMMIT PREPARED 'test1' I think we've seen this extra-transactions symptom before, but I don't recall the details at this late hour. regards, tom lane