From: Tom Lane <tgl@sss.pgh.pa.us>
To: Robert Haas <robertmhaas@gmail.com>
cc: Andrew Dunstan <andrew@dunslane.net>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Fix our Windows stat() emulation to handle file sizes >
 4GB.
In-reply-to: 
 <CA+TgmoZ-_edH0TVCaN0=XHHCs9b51-bfKCWvpVNCwwzUyRNUHA@mail.gmail.com>
References: <E1t9Bms-000hQQ-Np@gemulon.postgresql.org>
 <CA+TgmoZ-_edH0TVCaN0=XHHCs9b51-bfKCWvpVNCwwzUyRNUHA@mail.gmail.com>
Comments: In-reply-to Robert Haas <robertmhaas@gmail.com>
	message dated "Fri, 08 Nov 2024 08:45:27 -0500"
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-ID: <3647359.1731081780.1@sss.pgh.pa.us>
Content-Transfer-Encoding: quoted-printable
Date: Fri, 08 Nov 2024 11:03:00 -0500
Message-ID: <3647360.1731081780@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3647360.1731081780%40sss.pgh.pa.us>
Precedence: bulk

Robert Haas <robertmhaas@gmail.com> writes:
> On Thu, Nov 7, 2024 at 6:19=E2=80=AFPM Andrew Dunstan <andrew@dunslane.n=
et> wrote:
>> Juan Jos=C3=A9 Santamar=C3=ADa Flecha, reviewed by Emil Iggland;
>> based on prior work by Michael Paquier, Sergey Zubkovsky, and others
>> =

>> Author: Alexandra Wang <alexandra.wang.oss@gmail.com>

> This authorship information is confusing.

Yes.  Worse, there is no link to what prompted this sudden burst
of back-patches of years-old commits.  After digging around I guess
it was this thread:

https://www.postgresql.org/message-id/flat/CA%2BpA0kLc5VxOaO4WfLjmh7W0V%2B=
quVvVtT5CaRVRAZMuh0zft4Q%40mail.gmail.com

I'm nervous about pushing these in mere hours before a release freeze,
primarily because there's no way to be sure whether any necessary
follow-up fixes got missed.  If we were unwilling to back-patch at
the time, is reversing that decision such a good idea?

I'm also confused about how to document them in the release notes.
Alexandra should get some credit I guess for collecting and testing
the patches, but she's not the original author(s).

			regards, tom lane