From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
In-reply-to: <E1muynv-0006GS-R4@gemulon.postgresql.org>
References: <E1muynv-0006GS-R4@gemulon.postgresql.org>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Wed, 08 Dec 2021 15:24:23 +0000"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3655282.1638977975.1@sss.pgh.pa.us>
Date: Wed, 08 Dec 2021 10:39:35 -0500
Message-ID: <3655283.1638977975@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3655283.1638977975%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> Check that we have a working tar before trying to use it

I don't like the way you did this:

+         || system_log($tar, '--version') != 0);

ISTM that effectively restricts the test to only running
on machines with GNU tar, which basically removes all the
interest of it.  We know what GNU tar does ... it's the
weird legacy tar versions that might teach us something.
See 57b5a9646 for a recent example of the sort of bug
this test can no longer find.

			regards, tom lane