Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prgoB-0006f5-Uq for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Apr 2023 15:11:51 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1prgo9-0005ry-QT for pgsql-hackers@arkaria.postgresql.org; Wed, 26 Apr 2023 15:11:49 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1prgo9-0005ro-Gm for pgsql-hackers@lists.postgresql.org; Wed, 26 Apr 2023 15:11:49 +0000 Received: from relay9-d.mail.gandi.net ([2001:4b98:dc4:8::229]) by makus.postgresql.org with esmtps (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1prgo1-0020xt-U4 for pgsql-hackers@lists.postgresql.org; Wed, 26 Apr 2023 15:11:47 +0000 Received: (Authenticated sender: adsend@dunslane.net) by mail.gandi.net (Postfix) with ESMTPSA id 3669EFF806; Wed, 26 Apr 2023 15:11:34 +0000 (UTC) Content-Type: multipart/alternative; boundary="------------Pb5ptyqrlXBe3UlQ7qI00B8I" Message-ID: <365f59bd-1aaf-0af0-46ee-89e6a0dae391@dunslane.net> Date: Wed, 26 Apr 2023 11:11:33 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: issue with meson builds on msys2 Content-Language: en-US To: Tom Lane Cc: Andres Freund , pgsql-hackers@lists.postgresql.org References: <08dd6053-deee-52e9-954b-eb69232905c9@dunslane.net> <2506819.1681761221@sss.pgh.pa.us> <7d7dcc20-ba19-5340-9be8-f255e8b42edc@dunslane.net> <20230420150652.jciazjap223iznjp@awork3.anarazel.de> <5bddd941-9819-6655-7a71-3f346050583e@dunslane.net> <6efeb45a-07f9-2291-c8f8-9fb4abbb6ebc@dunslane.net> <848511.1682519554@sss.pgh.pa.us> <851356.1682521091@sss.pgh.pa.us> From: Andrew Dunstan In-Reply-To: <851356.1682521091@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk This is a multi-part message in MIME format. --------------Pb5ptyqrlXBe3UlQ7qI00B8I Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2023-04-26 We 10:58, Tom Lane wrote: > I wrote: >> Looking at the pg_ctl source code, the only way I can explain that >> printout is that do_stop called wait_for_postmaster_stop which, >> after one or more loops, exited via one of its exit() calls. > Ah, a little too hasty there: it's get_pgpid() that has to be > reaching an exit(). If I redirect the output to a file (which is what the buildfarm client actually does), it seems like it completes successfully, but I still get a non-zero exit: pgrunner@EC2AMAZ-GCB871B UCRT64 ~/bf $ /usr/bin/perl -e 'chdir "root/HEAD/instkeep.2023-04-25_11-09-41"; system("bin/pg_ctl -D data-C -l logfile stop > stoplog 2>&1") ; print "BANG\n" if $?; ' BANG pgrunner@EC2AMAZ-GCB871B UCRT64 ~/bf $ cat root/HEAD/instkeep.2023-04-25_11-09-41/stoplog waiting for server to shut down.... done server stopped It seems more than odd that we get to where the "server stopped" massage is printed but we get a failure. cheers andrew -- Andrew Dunstan EDB:https://www.enterprisedb.com --------------Pb5ptyqrlXBe3UlQ7qI00B8I Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: 7bit


On 2023-04-26 We 10:58, Tom Lane wrote:
I wrote:
Looking at the pg_ctl source code, the only way I can explain that
printout is that do_stop called wait_for_postmaster_stop which,
after one or more loops, exited via one of its exit() calls.
Ah, a little too hasty there: it's get_pgpid() that has to be
reaching an exit().



If I redirect the output to a file (which is what the buildfarm client actually does), it seems like it completes successfully, but I still get a non-zero exit:


pgrunner@EC2AMAZ-GCB871B UCRT64 ~/bf
$ /usr/bin/perl -e 'chdir "root/HEAD/instkeep.2023-04-25_11-09-41"; system("bin/pg_ctl -D data-C -l logfile stop > stoplog 2>&1") ; print "BANG\n" if $?; '
BANG

pgrunner@EC2AMAZ-GCB871B UCRT64 ~/bf
$ cat root/HEAD/instkeep.2023-04-25_11-09-41/stoplog
waiting for server to shut down.... done
server stopped


It seems more than odd that we get to where the "server stopped" massage is printed but we get a failure.


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com
--------------Pb5ptyqrlXBe3UlQ7qI00B8I--