pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Improve some publication-related error messages
5+ messages / 2 participants
[nested] [flat]

* pgsql: Improve some publication-related error messages
@ 2022-09-27 12:12 Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 0 replies; 5+ messages in thread

From: Alvaro Herrera @ 2022-09-27 12:12 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Improve some publication-related error messages

While at it, remove an unused queryString parameter from
CheckPubRelationColumnList() and make other minor stylistic changes.

Backpatch to 15.

Reported by Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Co-authored-by: Hou zj <houzj.fnst@fujitsu.com>
Discussion: https://postgr.es/m/20220926.160426.454497059203258582.horikyota.ntt@gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/4148c8b3daf95ca308f055e103f6ee82e25b8f99

Modified Files
--------------
src/backend/commands/publicationcmds.c    | 57 ++++++++++++++++++-------------
src/test/regress/expected/publication.out | 26 +++++++-------
2 files changed, 47 insertions(+), 36 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* pgsql: Improve some publication-related error messages
@ 2022-09-27 12:12 Alvaro Herrera <alvherre@alvh.no-ip.org>
  2022-09-27 13:46 ` Re: pgsql: Improve some publication-related error messages Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 5+ messages in thread

From: Alvaro Herrera @ 2022-09-27 12:12 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Improve some publication-related error messages

While at it, remove an unused queryString parameter from
CheckPubRelationColumnList() and make other minor stylistic changes.

Backpatch to 15.

Reported by Kyotaro Horiguchi <horikyota.ntt@gmail.com>
Co-authored-by: Hou zj <houzj.fnst@fujitsu.com>
Discussion: https://postgr.es/m/20220926.160426.454497059203258582.horikyota.ntt@gmail.com

Branch
------
REL_15_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f5441b912493e14fc2ca904971aeb000ceddca4e

Modified Files
--------------
src/backend/commands/publicationcmds.c    | 57 ++++++++++++++++++-------------
src/test/regress/expected/publication.out | 26 +++++++-------
2 files changed, 47 insertions(+), 36 deletions(-)



^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Improve some publication-related error messages
  2022-09-27 12:12 pgsql: Improve some publication-related error messages Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2022-09-27 13:46 ` Tom Lane <tgl@sss.pgh.pa.us>
  2022-09-27 13:55   ` Re: pgsql: Improve some publication-related error messages Alvaro Herrera <alvherre@alvh.no-ip.org>
  0 siblings, 1 reply; 5+ messages in thread

From: Tom Lane @ 2022-09-27 13:46 UTC (permalink / raw)
  To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: pgsql-committers@lists.postgresql.org

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> Improve some publication-related error messages

This is really not the sort of stuff to be pushing during a release
freeze.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Improve some publication-related error messages
  2022-09-27 12:12 pgsql: Improve some publication-related error messages Alvaro Herrera <alvherre@alvh.no-ip.org>
  2022-09-27 13:46 ` Re: pgsql: Improve some publication-related error messages Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-09-27 13:55   ` Alvaro Herrera <alvherre@alvh.no-ip.org>
  2022-09-27 14:02     ` Re: pgsql: Improve some publication-related error messages Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 5+ messages in thread

From: Alvaro Herrera @ 2022-09-27 13:55 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org

On 2022-Sep-27, Tom Lane wrote:

> Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> > Improve some publication-related error messages
> 
> This is really not the sort of stuff to be pushing during a release
> freeze.

My mistake.  I thought I had seen the tag -committers message go by, but
I must have been confused with the stamp one.

-- 
Álvaro Herrera               48°01'N 7°57'E  —  https://www.EnterpriseDB.com/
"La victoria es para quien se atreve a estar solo"





^ permalink  raw  reply  [nested|flat] 5+ messages in thread

* Re: pgsql: Improve some publication-related error messages
  2022-09-27 12:12 pgsql: Improve some publication-related error messages Alvaro Herrera <alvherre@alvh.no-ip.org>
  2022-09-27 13:46 ` Re: pgsql: Improve some publication-related error messages Tom Lane <tgl@sss.pgh.pa.us>
  2022-09-27 13:55   ` Re: pgsql: Improve some publication-related error messages Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2022-09-27 14:02     ` Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 5+ messages in thread

From: Tom Lane @ 2022-09-27 14:02 UTC (permalink / raw)
  To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: pgsql-committers@lists.postgresql.org

Alvaro Herrera <alvherre@alvh.no-ip.org> writes:
> My mistake.  I thought I had seen the tag -committers message go by, but
> I must have been confused with the stamp one.

Nope, the 24-hour window for packager complaints still has 7 or so
hours to run.

BTW, maybe you know something about this --- lately, it seems like
the tag commit's email gets held up in moderation, and thus is
delayed even more.  If you're looking directly at the state of the
repo you won't be fooled, but if you're waiting for the email then
there's a lot of unnecessary delay.  Can we fix that?

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 5+ messages in thread


end of thread, other threads:[~2022-09-27 14:02 UTC | newest]

Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-09-27 12:12 pgsql: Improve some publication-related error messages Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-09-27 12:12 pgsql: Improve some publication-related error messages Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-09-27 13:46 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-09-27 13:55   ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2022-09-27 14:02     ` Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox