Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkUXk-00076t-Na for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Apr 2023 18:41:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pkUXj-0000T0-AK for pgsql-hackers@arkaria.postgresql.org; Thu, 06 Apr 2023 18:41:07 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkUXj-0000Sj-0r for pgsql-hackers@lists.postgresql.org; Thu, 06 Apr 2023 18:41:07 +0000 Received: from smtp.outgoing.loopia.se ([93.188.3.37]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pkUXc-0003eN-D4 for pgsql-hackers@lists.postgresql.org; Thu, 06 Apr 2023 18:41:06 +0000 Received: from s807.loopia.se (localhost [127.0.0.1]) by s807.loopia.se (Postfix) with ESMTP id 18FF02F7C836 for ; Thu, 6 Apr 2023 20:40:58 +0200 (CEST) Received: from s979.loopia.se (unknown [172.22.191.6]) by s807.loopia.se (Postfix) with ESMTP id 08CFB2E2946C; Thu, 6 Apr 2023 20:40:58 +0200 (CEST) Received: from s473.loopia.se (unknown [172.22.191.6]) by s979.loopia.se (Postfix) with ESMTP id EFA5810BC34C; Thu, 6 Apr 2023 20:40:57 +0200 (CEST) X-Virus-Scanned: amavisd-new at amavis.loopia.se X-Spam-Flag: NO X-Spam-Score: -1 X-Spam-Level: X-Spam-Status: No, score=-1 tagged_above=-999 required=6.2 tests=[ALL_TRUSTED=-1] autolearn=disabled Received: from s934.loopia.se ([172.22.191.6]) by s473.loopia.se (s473.loopia.se [172.22.190.13]) (amavisd-new, port 10024) with LMTP id 6igW7h0Jlfpr; Thu, 6 Apr 2023 20:40:56 +0200 (CEST) X-Loopia-Auth: user X-Loopia-User: daniel@yesql.se X-Loopia-Originating-IP: 89.255.232.193 Received: from smtpclient.apple (customer-89-255-232-193.stosn.net [89.255.232.193]) (Authenticated sender: daniel@yesql.se) by s934.loopia.se (Postfix) with ESMTPSA id B2E567CEA99; Thu, 6 Apr 2023 20:40:55 +0200 (CEST) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3696.120.41.1.2\)) Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump) From: Daniel Gustafsson In-Reply-To: Date: Thu, 6 Apr 2023 20:40:55 +0200 Cc: Tomas Vondra , Michael Paquier , Christoph Berg , Tomas Vondra , Jacob Champion , Andres Freund , pgsql-hackers@lists.postgresql.org Content-Transfer-Encoding: quoted-printable Message-Id: <367105C9-D199-4D0A-B3D4-B07113440065@yesql.se> References: <819f6883-f7cf-74fd-e918-4c06a9d76d0b@enterprisedb.com> <0e8e53fa-5087-2151-dcd6-a1d3ad3ed493@enterprisedb.com> <74f02417-d18a-71dd-a406-8af41cbeb6c4@enterprisedb.com> To: Justin Pryzby X-Mailer: Apple Mail (2.3696.120.41.1.2) List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk > On 6 Apr 2023, at 18:39, Justin Pryzby wrote: > *If* you wanted to do something to fix this, you could create a key > called files_to_remove_after_loading, and run unlink on those files > rather than running a shell command. Or maybe just remove the file > unconditionally at the start of the script ? Since the test is written in Perl, and Perl has a function for deleting = files which abstracts the platform differences, using it seems like a logical = choice? {cleanup_cmd} can be replaced with {cleanup_files} with an unlink called = on that? -- Daniel Gustafsson