From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
cc: Robert Haas <rhaas@postgresql.org>, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Allow db.schema.table patterns,
 but complain about random garbag
In-reply-to: <3a190754-b2b0-d02b-dcfd-4ec1610ffbcb@dunslane.net>
References: <E1nhCcm-000HvW-AT@gemulon.postgresql.org>
 <3a190754-b2b0-d02b-dcfd-4ec1610ffbcb@dunslane.net>
Comments: In-reply-to Andrew Dunstan <andrew@dunslane.net>
	message dated "Fri, 22 Apr 2022 09:15:31 -0400"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3687647.1650636245.1@sss.pgh.pa.us>
Date: Fri, 22 Apr 2022 10:04:05 -0400
Message-ID: <3687648.1650636245@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3687648.1650636245%40sss.pgh.pa.us>
Precedence: bulk

Andrew Dunstan <andrew@dunslane.net> writes:
> This has upset the buildfarm's msys2 animals. There appears to be some
> wildcard expansion going on that causes the problem. I don't know why it
> should here when it's not causing trouble elsewhere. I have tried
> changing the way the tests are quoted, without success. Likewise,
> setting SHELLOPTS=noglob didn't work.

> At this stage I'm fresh out of ideas to fix it. It's also quite possible
> that my diagnosis is wrong.

When I was looking at this patch, I thought the number of test cases
was very substantially out of line anyway.  I suggest that rather
than investing a bunch of brain cells trying to work around this,
we just remove the failing test cases.

			regards, tom lane