Message-ID: <3703845a-5625-471b-a289-c23615a1b084@technowledgy.de>
Date: Tue, 8 Apr 2025 17:17:21 +0200
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: pgsql: Add support for basic NUMA awareness
Content-Language: en-US
To: Andres Freund <andres@anarazel.de>, Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org, Daniel Gustafsson
 <daniel@yesql.se>, Tomas Vondra <tomas.vondra@postgresql.org>
References: <E1u1tr8-003BbL-20@gemulon.postgresql.org>
 <7ABC1680-3B82-4DD4-B9B7-BB4F74668B1A@yesql.se>
 <3976705.1744121148@sss.pgh.pa.us>
 <87592CF0-5F4E-4043-BC57-E635E0924995@anarazel.de>
 <3979923.1744122992@sss.pgh.pa.us>
 <ez6juwhvrmvfviekshf7zmt2g4cuwjxlvdot5exeze4qkvdjj7@7yogvfvtspt3>
From: Wolfgang Walther <walther@technowledgy.de>
In-Reply-To: <ez6juwhvrmvfviekshf7zmt2g4cuwjxlvdot5exeze4qkvdjj7@7yogvfvtspt3>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Archived-At: 
 <https://www.postgresql.org/message-id/3703845a-5625-471b-a289-c23615a1b084%40technowledgy.de>
Precedence: bulk

Andres Freund:
> But I'm rather bewildered - I can't actually build with the professed version
> of ninja, it errors out:
>
> ninja-1.9.0 src/bin/psql/sql_help.c
> ninja: error: build.ninja:8462: multiple outputs aren't (yet?) supported by depslog; bring this up on the mailing list if it affects you
>
> So this must be some version of ninja between 1.9 and 1.10 (where the multiple
> outputs support was added).
>
> What's particularly weird about that is that the rest of the distro seems much
> newer. gcc 14.2.1, meson 1.6.1, LLVM 18. What's a < 2020 ninja doing with
> those surroundings?

The Dockerfile for the image running dogfish is at [1]. I'm installing 
the package "ninja" there, which... doesn't even exist upstream [2]. 
Odd. There is ninja-build, though, which is at 1.12.1. [3]

Turns out that the "ninja" I am installing is provided by samurai [4], 
which seems to be a drop-in replacement [5] for ninja:

 > samurai implements the ninja build language through version 1.9.0 
except for MSVC dependency handling (deps = msvc). It uses the same 
format for .ninja_log and .ninja_deps as ninja, currently version 5 and 
4 respectively.

I have not followed the remainder of the thread.. would you rather have 
me try to switch to the real ninja, or should we keep samurai for some 
variation in the buildfarm?

Best,

Wolfgang

[1]: 
https://github.com/technowledgy/postgresql-buildfarm-alpine/blob/main/Dockerfile

[2]: 
https://pkgs.alpinelinux.org/packages?name=*ninja*&branch=v3.21&repo=&arch=x86_64&origin=&flagged=&maintainer=

[3]: https://pkgs.alpinelinux.org/package/v3.21/community/x86_64/ninja-build

[4]: https://pkgs.alpinelinux.org/package/v3.21/main/x86_64/samurai

[5]: https://github.com/michaelforney/samurai