Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oACAH-0006UF-HI for pgsql-committers@arkaria.postgresql.org; Sat, 09 Jul 2022 15:14:37 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1oACAF-0006pJ-7U for pgsql-committers@arkaria.postgresql.org; Sat, 09 Jul 2022 15:14:35 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oACAF-0006p8-0r for pgsql-committers@lists.postgresql.org; Sat, 09 Jul 2022 15:14:35 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oACA8-0002kt-Oj for pgsql-committers@lists.postgresql.org; Sat, 09 Jul 2022 15:14:34 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 269FEP4p3775999; Sat, 9 Jul 2022 11:14:25 -0400 From: Tom Lane To: Peter Eisentraut cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Move a comment In-reply-to: References: Comments: In-reply-to Peter Eisentraut message dated "Sat, 09 Jul 2022 11:23:37 -0000" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3775997.1657379665.1@sss.pgh.pa.us> Date: Sat, 09 Jul 2022 11:14:25 -0400 Message-ID: <3775998.1657379665@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Peter Eisentraut writes: > Move a comment from the to-be-deleted section of nodes.h to where it > might still be useful. Hm. I'm kind of sad that we lost - /* - * TAGS FOR RANDOM OTHER STUFF - * - * These are objects that aren't part of parse/plan/execute node tree - * structures, but we give them NodeTags anyway for identification - * purposes (usually because they are involved in APIs where we want to - * pass multiple object types through the same pointer). - */ Not quite sure where that info should be put now. Maybe nodes/README could get another para that explains what types of objects get treated as Nodes? regards, tom lane