From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
cc: Andres Freund <andres@anarazel.de>, Andrew Dunstan <andrew@dunslane.net>,
        pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
In-reply-to: <YbGr7ylYwE56l91B@paquier.xyz>
References: <3657697.1638980149@sss.pgh.pa.us>
 <b179201e-8451-6a5e-e9be-9c755a13be7f@dunslane.net>
 <3660797.1638983124@sss.pgh.pa.us>
 <b6782dc3-a7b0-ed56-175f-f8f54cb08d67@dunslane.net>
 <20211209021604.bv5tfr23ymh4u7x4@alap3.anarazel.de>
 <3707204.1639016334@sss.pgh.pa.us>
 <20211209024604.dpmudj4ax2hoi7cx@alap3.anarazel.de>
 <20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de>
 <YbGYe483803il3X7@paquier.xyz>
 <20211209064928.7f5lp6hxvw2f2j6o@alap3.anarazel.de>
 <YbGr7ylYwE56l91B@paquier.xyz>
Comments: In-reply-to Michael Paquier <michael@paquier.xyz>
	message dated "Thu, 09 Dec 2021 16:10:39 +0900"
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <3778565.1639057533.1@sss.pgh.pa.us>
Date: Thu, 09 Dec 2021 08:45:33 -0500
Message-ID: <3778566.1639057533@sss.pgh.pa.us>
Archived-At: 
 <https://www.postgresql.org/message-id/3778566.1639057533%40sss.pgh.pa.us>
Precedence: bulk

Michael Paquier <michael@paquier.xyz> writes:
> ...  I got some copies of tar.exe lying
> around, one from a git installation and a second one from Msys, but
> both don't work even if $ENV{TAR} points at them :/

What goes wrong exactly?

The test I proposed ("tar cf foo.tar foo") doesn't seem like it
will catch the actual problem, which IIUC is that these tars
don't like a drive letter in the file name(s).  Can we arrange
to strip that in what's passed to $TAR ?  If not, it seems like
we have to test for exactly that point (ie Windows-only test).

			regards, tom lane