Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIEjm-0006gh-4x for pgsql-committers@arkaria.postgresql.org; Wed, 18 Jan 2023 20:08:46 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pIEjk-00083q-UK for pgsql-committers@arkaria.postgresql.org; Wed, 18 Jan 2023 20:08:44 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIEjk-00081W-MT for pgsql-committers@lists.postgresql.org; Wed, 18 Jan 2023 20:08:44 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by magus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIEji-0006o9-Kz for pgsql-committers@lists.postgresql.org; Wed, 18 Jan 2023 20:08:44 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30IK8crA3787914; Wed, 18 Jan 2023 15:08:38 -0500 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Get rid of the "new" and "old" entries in a view's rangetable. In-reply-to: <20230118195855.7yjc4mminmv7iyy5@awork3.anarazel.de> References: <20230118195855.7yjc4mminmv7iyy5@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Wed, 18 Jan 2023 11:58:55 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3787912.1674072518.1@sss.pgh.pa.us> Date: Wed, 18 Jan 2023 15:08:38 -0500 Message-ID: <3787913.1674072518@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2023-01-18 18:24:45 +0000, Tom Lane wrote: >> Get rid of the "new" and "old" entries in a view's rangetable. > This seems to have caused a test failure on windows. Looks like it's not > indicating a real problem, just that collate.windows.win1252.out needs to be > adapted. Huh, I wonder why the cfbot never complained about that when it was testing this patch ... maybe it doesn't use win1252? Will fix, thanks for letting me know. regards, tom lane