Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIF9y-0008Iq-4o for pgsql-committers@arkaria.postgresql.org; Wed, 18 Jan 2023 20:35:50 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.92) (envelope-from ) id 1pIF9w-0005oJ-BH for pgsql-committers@arkaria.postgresql.org; Wed, 18 Jan 2023 20:35:48 +0000 Received: from makus.postgresql.org ([2001:4800:3e1:1::229]) by malur.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIF9w-0005oA-46 for pgsql-committers@lists.postgresql.org; Wed, 18 Jan 2023 20:35:48 +0000 Received: from sss.pgh.pa.us ([66.207.139.130]) by makus.postgresql.org with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pIF9t-0002y7-M8 for pgsql-committers@lists.postgresql.org; Wed, 18 Jan 2023 20:35:47 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 30IKZfr83804195; Wed, 18 Jan 2023 15:35:41 -0500 From: Tom Lane To: Andres Freund cc: pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Get rid of the "new" and "old" entries in a view's rangetable. In-reply-to: <20230118201451.f2dooawchsfy57qc@awork3.anarazel.de> References: <20230118195855.7yjc4mminmv7iyy5@awork3.anarazel.de> <3787913.1674072518@sss.pgh.pa.us> <20230118201451.f2dooawchsfy57qc@awork3.anarazel.de> Comments: In-reply-to Andres Freund message dated "Wed, 18 Jan 2023 12:14:51 -0800" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3804193.1674074141.1@sss.pgh.pa.us> Date: Wed, 18 Jan 2023 15:35:41 -0500 Message-ID: <3804194.1674074141@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Andres Freund writes: > On 2023-01-18 15:08:38 -0500, Tom Lane wrote: >> Huh, I wonder why the cfbot never complained about that when >> it was testing this patch ... maybe it doesn't use win1252? > This is the same environment that cfbot is also using, so this is odd. And > cfbot has been failing on windows since the commit went into master: > https://cirrus-ci.com/github/postgresql-cfbot/postgresql/ > So I guess something must have changed in the patch since then? I guess it > could be that something changed on the VM, but I don't think so... Hmmm ... the collate.windows.win1252 test did not exist at all before 3-Jan (bf03cfd16), while 1b4d280ea went in on 11-Jan. So perhaps the most plausible theory is that the cfbot didn't test this patch between those dates. It should certainly have noticed if it did run it ... regards, tom lane