Received: from malur.postgresql.org ([217.196.149.56]) by arkaria.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhEEJ-00AJqq-SU for pgsql-committers@arkaria.postgresql.org; Mon, 04 Mar 2024 19:44:08 +0000 Received: from localhost ([127.0.0.1] helo=malur.postgresql.org) by malur.postgresql.org with esmtp (Exim 4.94.2) (envelope-from ) id 1rhEEI-00APSm-G4 for pgsql-committers@arkaria.postgresql.org; Mon, 04 Mar 2024 19:44:06 +0000 Received: from magus.postgresql.org ([2a02:c0:301:0:ffff::29]) by malur.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhEEI-00APSe-A2 for pgsql-committers@lists.postgresql.org; Mon, 04 Mar 2024 19:44:06 +0000 Received: from sss.pgh.pa.us ([68.162.161.243]) by magus.postgresql.org with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhEEG-002lt2-55 for pgsql-committers@lists.postgresql.org; Mon, 04 Mar 2024 19:44:06 +0000 Received: from sss1.sss.pgh.pa.us (localhost [127.0.0.1]) by sss.pgh.pa.us (8.15.2/8.15.2) with ESMTP id 424JhxaK3859051; Mon, 4 Mar 2024 14:43:59 -0500 From: Tom Lane To: Daniel Gustafsson cc: Andrew Dunstan , Alvaro Herrera , pgsql-committers@lists.postgresql.org Subject: Re: pgsql: Remove the adminpack contrib extension In-reply-to: References: <202403041527.k2fsmwdgf6fy@alvherre.pgsql> <0D569522-B87D-4178-A15E-9751905614EF@yesql.se> <3690275.1709570049@sss.pgh.pa.us> Comments: In-reply-to Daniel Gustafsson message dated "Mon, 04 Mar 2024 20:08:16 +0100" MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <3859049.1709581439.1@sss.pgh.pa.us> Content-Transfer-Encoding: quoted-printable Date: Mon, 04 Mar 2024 14:43:59 -0500 Message-ID: <3859050.1709581439@sss.pgh.pa.us> List-Id: List-Help: List-Subscribe: List-Post: List-Owner: List-Archive: Archived-At: Precedence: bulk Daniel Gustafsson writes: > The deviation between database names on crake found in the follow-up com= mit is > a bit concerning. Too much magic hidden away from the codetree makes it= hard > to get tests right on the first try. Yeah, I didn't understand that at all. I have a non-reporting buildfarm setup here that I run when it's necessary to debug these cross-version tests, and it did not show this failure. crake itself was passing with the pre-16 branches, so I'm mystified why 16 is different. Anyway, I see it's green now, so all good. regards, tom lane